New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batchedStatements is not taken into account #21

Closed

eric-taix opened this issue Dec 26, 2012 · 3 comments

eric-taix commented Dec 26, 2012

Even if I set batchedStatements=true, it is not taken into account and a SimplePrepareStatement is created instead of a PreparedBatchStatement !

In the TestConfigurationProcessor#buildConfiguration method, you missed some withXXXX methods !

withBatchedStatements(annotation.batchedStatements())
withBatchSize(annotation.batchSize())

and perhaps more ;-)

Contributor

slandelle commented Dec 27, 2012

Are you sure this hasn't already been fixed?
https://github.com/excilys/spring-dbunit/blob/master/spring-dbunit-test/src/main/java/com/excilys/ebi/spring/dbunit/test/TestConfigurationProcessor.java#L109

Which version do you use?

Author

eric-taix commented Dec 27, 2012

You're right, I used version 1.1.8 but I was sure to be uptodate
=> Eclipse maven plugin didn't show me version 1.1.12 :-(

I'll have a look to my nexus conf.
Thanks for the good job and sorry.

Contributor

slandelle commented Dec 27, 2012

No pro :)

Note that I had to remove tons of old versions of our projects from our Nexus in order to facilitate a migration, so you'll only have 1.1.12 in there.

slandelle closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment