Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in DataSetTestExecutionListener at line 86 (Version 1.4.0) #52

Open
jtchatchoua opened this issue Sep 2, 2016 · 0 comments
Open

Comments

@jtchatchoua
Copy link

private void checkDatas(TestContext testContext) throws Exception {
ExpectedDataSetConfiguration expectedConfiguration = getExpectedConfiguration(testContext);
if (expectedConfiguration != null) {
IDataSet expectedDataSet = expectedConfiguration.getDataSet();
for (String tableName : expectedDataSet.getTableNames()) {
IDataSet dataSet = dataReader.execute(testContext.getApplicationContext(), getExpectedConfiguration(testContext), tableName);
String[] columnsToIgnore = expectedConfiguration.getColumnsToIgnore();
if (columnsToIgnore == null || columnsToIgnore.length == 0) {

              `Assertion.assertEquals(expectedDataSet, dataSet);`

// When the dataset has more than one table, test fails when compare tableNames length. I think the code here should be
Assertion.assertEquals(expectedDataSet.getTable(tableName), dataSet.getTable(tableName));

            } else {
                Assertion.assertEqualsIgnoreCols(expectedDataSet, dataSet, tableName, columnsToIgnore);
            }
        }
    }
@jtchatchoua jtchatchoua changed the title Bug in DataSetTestExecutionListener at line 96 (Version 1.4.0) Bug in DataSetTestExecutionListener at line 86 (Version 1.4.0) Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant