Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled requests are executed after cache invalidation #648

Closed
livyk opened this issue Jun 28, 2020 · 4 comments
Closed

Disabled requests are executed after cache invalidation #648

livyk opened this issue Jun 28, 2020 · 4 comments
Labels

Comments

@livyk
Copy link

livyk commented Jun 28, 2020

Describe the bug
Disabled requests are executed after cache invalidation

To Reproduce
Steps to reproduce the behavior:
1 Use useQuery hook with the "items" key and pass {enabled: false} to the settings
2. Call queryCache.invalidateQueries("items")
3. The request will be fulfilled despite {enabled: false}

Expected behavior
The request will not be executed after the cache is invalidated, because in its settings it is {enabled: false}

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome 83
  • Version 2.4.2

Additional context
Sandbox

@GuillaumeSpera
Copy link

Hi there, might me a duplicate of my issue #635. If so, it has been fixed in new release

@livyk
Copy link
Author

livyk commented Jun 28, 2020

The bug is still reproduced in version 2.4.2

@GuillaumeSpera
Copy link

Yep, you are right. My issue is also still reproduced in version 2.4.2

@tannerlinsley
Copy link
Collaborator

🎉 This issue has been resolved in version 2.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants