Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clj-kondo warnings #32

Open
ptaoussanis opened this issue Oct 23, 2024 · 8 comments
Open

Fix clj-kondo warnings #32

ptaoussanis opened this issue Oct 23, 2024 · 8 comments
Labels
can close? Can be closed? enhancement New feature or request help wanted Extra attention is needed pull requests welcome Looking for PRs 👍's welcome Looking for upvotes to gauge interest level

Comments

@ptaoussanis
Copy link
Member

Currently, it looks like clj-kondo generates spurious warnings for Telemere (Ref. Slack):

image_480

I'm not familiar with with clj-kondo, but as I understand it - Telemere could help get rid of these warnings by including some sort of relevant data file.

This'd be a good first PR if someone familiar with clj-kondo wants to help out. Feel free to ping if I can provide any assistance re: relevant signatures / arg types / etc.

In the meantime, my understanding is that the following config will suppress the spurious warnings (Ref. Slack):

{:linters
 {:unresolved-var
  {:exclude [taoensso.telemere/*ctx*
             taoensso.telemere/add-handler!
             taoensso.telemere/handler:console
             taoensso.telemere/handler:file
             taoensso.telemere/pr-signal-fn
             taoensso.telemere/set-ctx!
             taoensso.telemere/set-middleware!
             taoensso.telemere/stop-handlers!]}}}
@ptaoussanis ptaoussanis added enhancement New feature or request help wanted Extra attention is needed pull requests welcome Looking for PRs labels Oct 23, 2024
@ptaoussanis
Copy link
Member Author

Update: @rschmukler mentioned that running rm -rf .clj-kondo/.cache in the root of your project directory might remove the spurious warnings.

@ptaoussanis
Copy link
Member Author

Seems clearing the cache as mentioned above is indeed successful, so closing this issue.

@icp1994
Copy link

icp1994 commented Oct 29, 2024

I did try that before searching here, but didn't work for me
image

@ptaoussanis
Copy link
Member Author

@icp1994 To confirm, you tried to first run rm -rf .clj-kondo/.cache in the root of your project directory? Might restarting your IDE help?

@icp1994
Copy link

icp1994 commented Oct 29, 2024

Yes. I also started a fresh dummy project to make sure.

@ptaoussanis ptaoussanis reopened this Oct 29, 2024
@ptaoussanis
Copy link
Member Author

I'm not familiar with clj-kondo myself so unfortunately can't advise - but hopefully someone else might be able to.

@rschmukler Is there anything else you can suggest for @icp1994 to try? Thanks! 🙏 (Tagging you because of your comment on the Telemere Slack).

@icp1994
Copy link

icp1994 commented Oct 29, 2024

I think there needs to be separate config which users can import, like there is for nippy.

@ptaoussanis
Copy link
Member Author

ptaoussanis commented Oct 29, 2024

I think there needs to be separate config which users can import, like there is for nippy.

I'm hoping that might not be the case, since it seems there's at least two clj-kondo users here that have reported success after clearing their cache. Not sure though! Hopefully someone else familiar with clj-kondo can advise?

@ptaoussanis ptaoussanis added the 👍's welcome Looking for upvotes to gauge interest level label Nov 21, 2024
@ptaoussanis ptaoussanis added the can close? Can be closed? label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can close? Can be closed? enhancement New feature or request help wanted Extra attention is needed pull requests welcome Looking for PRs 👍's welcome Looking for upvotes to gauge interest level
Projects
None yet
Development

No branches or pull requests

2 participants