Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog workflow is broken #1871

Closed
andrewfullard opened this issue Jan 24, 2022 · 4 comments
Closed

Changelog workflow is broken #1871

andrewfullard opened this issue Jan 24, 2022 · 4 comments

Comments

@andrewfullard
Copy link
Contributor

Describe the bug

Changelog workflow is refusing to push, claiming that it hasn't got a branch checked out.

To Reproduce

Run changelog workflow

Screenshots

image

@madoyi
Copy link

madoyi commented Jan 26, 2022

I'd like to help out with this issue, is there a specific implementation you had in mind ?

@blackbird7112
Copy link
Contributor

blackbird7112 commented Jan 26, 2022

Hey, I have been exploring this issue for a day. actions/checkout#124 (comment) This comment explains the reason why this issue arises. I think a push to a PR related branch is also considered as a trigger. So we need to do some study regarding when this workflow should be called.

The simplest way to fix the issue will be through a git checkout and then performing the push.

Also I had a suggestion. I think we need to setup a conditional statement to prevent the workflow from running in forks of the repository. This is because the fork will not have the BOT_TOKEN secret and the workflow may give an error.

I would love to work on this issue.

@blackbird7112
Copy link
Contributor

blackbird7112 commented Jan 26, 2022

I have a made a mistake in my previous comment. After testing the workflow on my fork, I have realised that the workflow is being triggered correctly and the PR is not causing the error. The detached head occurs due to the way git handles tags. When we make a commit over the tag, the commit is not attached to any branch. The tag still points to the previous commit. So we need to modify the tag accordingly to handle this change.

@epassaro
Copy link
Member

Replaced by the pre-release workflow.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants