-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog workflow is broken #1871
Comments
I'd like to help out with this issue, is there a specific implementation you had in mind ? |
Hey, I have been exploring this issue for a day. actions/checkout#124 (comment) This comment explains the reason why this issue arises. I think a push to a PR related branch is also considered as a trigger. So we need to do some study regarding when this workflow should be called. The simplest way to fix the issue will be through a Also I had a suggestion. I think we need to setup a conditional statement to prevent the workflow from running in forks of the repository. This is because the fork will not have the I would love to work on this issue. |
I have a made a mistake in my previous comment. After testing the workflow on my fork, I have realised that the workflow is being triggered correctly and the PR is not causing the error. The detached head occurs due to the way git handles tags. When we make a commit over the tag, the commit is not attached to any branch. The tag still points to the previous commit. So we need to modify the tag accordingly to handle this change. |
Replaced by the pre-release workflow. Closing. |
Describe the bug
Changelog workflow is refusing to push, claiming that it hasn't got a branch checked out.
To Reproduce
Run changelog workflow
Screenshots
The text was updated successfully, but these errors were encountered: