Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change M_PI to not use arccos #2863

Closed
wkerzendorf opened this issue Oct 21, 2024 · 1 comment
Closed

change M_PI to not use arccos #2863

wkerzendorf opened this issue Oct 21, 2024 · 1 comment
Labels
easy good first issue

Comments

@wkerzendorf
Copy link
Member

Throughout the code M_PI is sometimes defined as np.arccos(1) but we should just use the numpy pi implementation
@Akash265 Akash265 mentioned this issue Nov 1, 2024
Merged
6 tasks
@Akash265
Copy link
Contributor

Akash265 commented Nov 1, 2024

Fixed the issue by replacing M_PI=np.arccos(-1) with M_PI=np.pi in the codebase, as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wkerzendorf @andrewfullard @Akash265