Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ScanIso Failing to Extract Some ISOs #401

Closed
ryanohoro opened this issue Sep 27, 2023 · 1 comment
Closed

[BUG] ScanIso Failing to Extract Some ISOs #401

ryanohoro opened this issue Sep 27, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ryanohoro
Copy link
Collaborator

ryanohoro commented Sep 27, 2023

Describe the bug

ScanIso is reporting iso_read_error for known malicious ISO samples that 7zip can successfully extract.

Environment details

Steps to reproduce

  1. Download 697c62edf58a882e8c62cd5b8e303a69a08bd73e8384327c7591bd1b95c75302
  2. Upload the file to Fileshot UI
  3. Observe ScanIso setting the iso_read_error flag, "extracted": 0.
  4. Run 7zz x on the file
  5. Observe 7zip successfully extracting the ISO contents
$ 7zz x 697c62edf58a882e8c62cd5b8e303a69a08bd73e8384327c7591bd1b95c75302 

7-Zip (z) 22.01 (x64) : Copyright (c) 1999-2022 Igor Pavlov : 2022-07-15
 64-bit locale=en_US.UTF-8 Threads:8

Scanning the drive for archives:
1 file, 1245184 bytes (1216 KiB)

Extracting archive: 697c62edf58a882e8c62cd5b8e303a69a08bd73e8384327c7591bd1b95c75302

WARNINGS:
There are data after the end of archive

--
Path = 697c62edf58a882e8c62cd5b8e303a69a08bd73e8384327c7591bd1b95c75302
Type = Iso
WARNINGS:
There are data after the end of archive
Physical Size = 1226752
Tail Size = 18432
Comment = 
{

Volume: CARRIER_TENDER
VolumeSet: UNDEFINED
Application: IMGBURN V2.5.8.0 - THE ULTIMATE IMAGE BURNER!
}
Created = 2023-07-27 15:18:04.00
Modified = 2023-07-27 15:18:04.00

Everything is Ok

Archives with Warnings: 1

Warnings: 1
Size:       1223
Compressed: 1245184

$ ls -l
-rw-rw-r-- 1 user user 1245184 Nov 30  1979 697c62edf58a882e8c62cd5b8e303a69a08bd73e8384327c7591bd1b95c75302
-rw-rw-r-- 1 user user    1223 Jul 27 04:16 CARRIER_.LNK

Expected behavior

ScanIso should be able to successfully extract the contents of the ISO.

Screenshots

Release

  • Release: 0.23.09.12

Additional context

{
  "elapsed": 0.003614,
  "flags": [
    "iso_read_error"
  ],
  "meta": {
    "date_created": "2023-07-27T20:18:04",
    "date_modification": "2023-07-27T20:18:04",
    "volume_identifier": "CARRIER_TENDER                  "
  },
  "total": {
    "extracted": 0,
    "files": 0
  }
}
@ryanohoro ryanohoro added the bug Something isn't working label Sep 27, 2023
@ryanohoro
Copy link
Collaborator Author

This issue was related to an internal fork and has been resolved with a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants