Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ScanQR Type Assertions #404

Closed
phutelmyer opened this issue Oct 23, 2023 · 1 comment
Closed

[BUG] ScanQR Type Assertions #404

phutelmyer opened this issue Oct 23, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@phutelmyer
Copy link
Contributor

Describe the bug
When reviewing ScanQR events, it was observed that the type field often had the value "undefined." Furthermore, there were numerous URLs in the collection that were not included in the ScanQR URL regex. This has raised concerns about the reliability and relevance of the "type" field in ScanQR results.

The primary concern here is whether it is appropriate to continue attempting to assert a "type" for QR codes. Given the nature of QR codes, which can encode a wide variety of data types (URLs, text, contact information, etc.), it might not be practical to accurately determine a specific "type" for every QR code.

Proposed recommendation is to remove the type field rather than try to ensure it is continuously updated with possible permutations.

Environment details
N/A

Pytest Output
N/A

@phutelmyer phutelmyer added the bug Something isn't working label Oct 23, 2023
@phutelmyer phutelmyer self-assigned this Oct 23, 2023
@ryanohoro ryanohoro mentioned this issue Oct 24, 2023
5 tasks
@phutelmyer
Copy link
Contributor Author

Fixed in #406 by @ryanohoro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant