Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pinning] Finalize the configuration about pinning #287

Closed
2 tasks done
giomfo opened this issue Nov 24, 2021 · 0 comments
Closed
2 tasks done

[Pinning] Finalize the configuration about pinning #287

giomfo opened this issue Nov 24, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@giomfo
Copy link
Contributor

giomfo commented Nov 24, 2021

The pinning dimension has been introduced here (#24)

After thinking the fingerprints of the certificates won't be whitelisted in the withPinning variant, only the root certificat will be imposed thanks to the network_security_config.xml

This network_security_config.xml is already defined and correct for the withPinning variant here

We request here:

  • apply the network_security_config of Element-Android to the withoutPinning variant. We should "git move" this xml file there
  • remove the PinningConfiguration.kt files from all variants, because the defined items are not used anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants