Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All props shows required in api-ref tab #7230

Closed
mingenesis opened this issue Mar 31, 2023 · 2 comments · Fixed by #7238
Closed

All props shows required in api-ref tab #7230

mingenesis opened this issue Mar 31, 2023 · 2 comments · Fixed by #7238
Labels
type/bug

Comments

@mingenesis
Copy link

mingenesis commented Mar 31, 2023 •
edited by sync-by-unito bot
Loading

https://bit.cloud/teambit/harmony/node/~api-reference?_gl=1*1h5ta3j*_ga*MTk3NjA4MDgwNC4xNjc2ODkyMjk5*_ga_C0T2GH2G99*MTY3NzU3NzMyNy4yMS4xLjE2Nzc1Nzg1NjQuNDcuMC4w&selectedAPI=NodeAppOptions

On this page, it can be seen that portRange should be optional. However, in the Properties table below, it is indicated as required after portRange.
@mingenesis mingenesis changed the title All All props shows required in api-ref tab Mar 31, 2023
@benjgil
Copy link
Contributor

benjgil commented Apr 2, 2023

@luvkapur

@luvkapur luvkapur linked a pull request Apr 3, 2023 that will close this issue
fix(APIReference): forward isOptional prop to variable node summary #7238
Merged
@mingenesis
Copy link
Author

Thank you @luvkapur ,
I updated bit to version 0.1.27, and the issue seems to be fixed on my local workspace. However, when I exported it to Bit Cloud, the problem of all properties displaying as required still exists. Can you help me identify the reason for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(APIReference): forward isOptional prop to variable node summary teambit/bit
2 participants
@mingenesis @benjgil