From 4d9daf71e7e531baedc4c1916f47f7c7fda0b011 Mon Sep 17 00:00:00 2001 From: Teddy Gustiaux Date: Mon, 29 Apr 2019 20:51:56 -0400 Subject: [PATCH] fix: bookmarking tabs not working properly in non-English UI (close #56) --- src/background/bookmarking/BuiltinBookmarking.js | 6 +++++- src/globals.js | 1 - 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/background/bookmarking/BuiltinBookmarking.js b/src/background/bookmarking/BuiltinBookmarking.js index 3667abf..6f4a298 100644 --- a/src/background/bookmarking/BuiltinBookmarking.js +++ b/src/background/bookmarking/BuiltinBookmarking.js @@ -23,8 +23,12 @@ class BuiltinBookmarking { return isSystemCreated; } + // The default name template is "[Folder Name]", but is language-specific _isAllTabsSystemCreatedFolder(bookmarkInfo) { - return bookmarkInfo.title === FIREFOX_DEFAULT_ALL_TABS_FOLDER_NAME; + if (bookmarkInfo.title.length < 3) return false; + const firstLetter = bookmarkInfo.title[0]; + const lastLetter = bookmarkInfo.title[bookmarkInfo.title.length - 1]; + return firstLetter === '[' && lastLetter === ']'; } _createMovingPropertiesForBookmark() { diff --git a/src/globals.js b/src/globals.js index d3e2df1..d7d7d68 100644 --- a/src/globals.js +++ b/src/globals.js @@ -37,7 +37,6 @@ const QUICK_BOOOKMARKING_COMMAND = 'quick-bookmark'; // Default bookmark folders ('unfiled' by default for all versions, 'menu' with shortcut/context menu on stable version) const FIREFOX_DEFAULT_FOLDERS = ['unfiled_____', 'menu________']; -const FIREFOX_DEFAULT_ALL_TABS_FOLDER_NAME = '[Folder Name]'; const FIREFOX_ROOT_BOOKMARK_FOLDER = 'root________'; // List of status