feat: display a notification if the feed could not be found

teddy-gustiaux · Nov 11, 2018 · 53eb70d · 53eb70d
1 parent 224738b
commit 53eb70d
Show file tree

Hide file tree

Showing 27 changed files with 55 additions and 22 deletions.
diff --git a/assets/icons/error.svg b/assets/icons/error.svg
diff --git a/assets/icon/youtube-rss-finder.svg → assets/icons/youtube-rss-finder.svg b/assets/icon/youtube-rss-finder.svg → assets/icons/youtube-rss-finder.svg
diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json
@@ -1,5 +1,8 @@
 {
     "pageActionTitle": {
       "message": "Display the RSS feed of this channel"
+    },
+    "feedRetrievalError": {
+      "message": "The RSS feed of this channel could not be found."
     }
 }
diff --git a/src/_locales/fr/messages.json b/src/_locales/fr/messages.json
@@ -1,5 +1,8 @@
 {
     "pageActionTitle": {
       "message": "Afficher le flux RSS de cette chaîne"
+    },
+    "feedRetrievalError": {
+      "message": "Le flux RSS de cette chaîne n'a pas pu être trouvé."
     }
 }
diff --git a/src/_locales/ru/messages.json b/src/_locales/ru/messages.json
@@ -1,5 +1,8 @@
 {
     "pageActionTitle": {
       "message": "Просмотреть RSS ленту этого канала"
+    },
+    "feedRetrievalError": {
+      "message": "The RSS feed of this channel could not be found."
     }
 }
diff --git a/src/background.js b/src/background.js
@@ -73,7 +73,6 @@ class Utils {
         } else if (url.split('/').length === 4) {
             identifier = Utils.buildFeedIdentifier(url, 'youtube.com/', 'user');
         }
-        console.log(identifier)
         if (identifier !== null) return FEED_BASE_URL + identifier;
         return null;
     }
@@ -115,6 +114,13 @@ async function onPageActionClick(tab) {
             url: feed,
             active: true,
         });
+    } else {
+        browser.notifications.create('', {
+            type: 'basic',
+            title: browser.runtime.getManifest().name,
+            message: browser.i18n.getMessage('feedRetrievalError'),
+            iconUrl: browser.extension.getURL('icons/error/error-96.png'),
+        });
     }
 }
 

diff --git a/src/icons/error/error-1024.png b/src/icons/error/error-1024.png
diff --git a/src/icons/error/error-128.png b/src/icons/error/error-128.png
diff --git a/src/icons/error/error-16.png b/src/icons/error/error-16.png
diff --git a/src/icons/error/error-24.png b/src/icons/error/error-24.png
diff --git a/src/icons/error/error-256.png b/src/icons/error/error-256.png
diff --git a/src/icons/error/error-32.png b/src/icons/error/error-32.png
diff --git a/src/icons/error/error-48.png b/src/icons/error/error-48.png
diff --git a/src/icons/error/error-512.png b/src/icons/error/error-512.png
diff --git a/src/icons/error/error-64.png b/src/icons/error/error-64.png
diff --git a/src/icons/error/error-96.png b/src/icons/error/error-96.png
diff --git a/src/icon/youtube-rss-finder-1024.png → src/icons/logo/youtube-rss-finder-1024.png b/src/icon/youtube-rss-finder-1024.png → src/icons/logo/youtube-rss-finder-1024.png
diff --git a/src/icon/youtube-rss-finder-128.png → src/icons/logo/youtube-rss-finder-128.png b/src/icon/youtube-rss-finder-128.png → src/icons/logo/youtube-rss-finder-128.png
diff --git a/src/icon/youtube-rss-finder-16.png → src/icons/logo/youtube-rss-finder-16.png b/src/icon/youtube-rss-finder-16.png → src/icons/logo/youtube-rss-finder-16.png
diff --git a/src/icon/youtube-rss-finder-24.png → src/icons/logo/youtube-rss-finder-24.png b/src/icon/youtube-rss-finder-24.png → src/icons/logo/youtube-rss-finder-24.png
diff --git a/src/icon/youtube-rss-finder-256.png → src/icons/logo/youtube-rss-finder-256.png b/src/icon/youtube-rss-finder-256.png → src/icons/logo/youtube-rss-finder-256.png
diff --git a/src/icon/youtube-rss-finder-32.png → src/icons/logo/youtube-rss-finder-32.png b/src/icon/youtube-rss-finder-32.png → src/icons/logo/youtube-rss-finder-32.png
diff --git a/src/icon/youtube-rss-finder-48.png → src/icons/logo/youtube-rss-finder-48.png b/src/icon/youtube-rss-finder-48.png → src/icons/logo/youtube-rss-finder-48.png
diff --git a/src/icon/youtube-rss-finder-512.png → src/icons/logo/youtube-rss-finder-512.png b/src/icon/youtube-rss-finder-512.png → src/icons/logo/youtube-rss-finder-512.png
diff --git a/src/icon/youtube-rss-finder-64.png → src/icons/logo/youtube-rss-finder-64.png b/src/icon/youtube-rss-finder-64.png → src/icons/logo/youtube-rss-finder-64.png
diff --git a/src/icon/youtube-rss-finder-96.png → src/icons/logo/youtube-rss-finder-96.png b/src/icon/youtube-rss-finder-96.png → src/icons/logo/youtube-rss-finder-96.png
diff --git a/src/manifest.json b/src/manifest.json
@@ -11,22 +11,23 @@
 
   "permissions": [
     "activeTab",
-    "tabs"
+    "tabs",
+    "notifications"
   ],
 
   "page_action": {
     "default_title": "__MSG_pageActionTitle__",
     "default_icon": {
-      "16": "icon/youtube-rss-finder-16.png",
-      "24": "icon/youtube-rss-finder-24.png",
-      "32": "icon/youtube-rss-finder-32.png",
-      "48": "icon/youtube-rss-finder-48.png",
-      "64": "icon/youtube-rss-finder-64.png",
-      "96": "icon/youtube-rss-finder-96.png",
-      "128": "icon/youtube-rss-finder-128.png",
-      "256": "icon/youtube-rss-finder-256.png",
-      "512": "icon/youtube-rss-finder-512.png",
-      "1024": "icon/youtube-rss-finder-1024.png"
+      "16": "icons/logo/youtube-rss-finder-16.png",
+      "24": "icons/logo/youtube-rss-finder-24.png",
+      "32": "icons/logo/youtube-rss-finder-32.png",
+      "48": "icons/logo/youtube-rss-finder-48.png",
+      "64": "icons/logo/youtube-rss-finder-64.png",
+      "96": "icons/logo/youtube-rss-finder-96.png",
+      "128": "icons/logo/youtube-rss-finder-128.png",
+      "256": "icons/logo/youtube-rss-finder-256.png",
+      "512": "icons/logo/youtube-rss-finder-512.png",
+      "1024": "icons/logo/youtube-rss-finder-1024.png"
     },
     "browser_style": true,
     "show_matches": [
@@ -37,16 +38,16 @@
   },
 
   "icons": {
-    "16": "icon/youtube-rss-finder-16.png",
-    "24": "icon/youtube-rss-finder-24.png",
-    "32": "icon/youtube-rss-finder-32.png",
-    "48": "icon/youtube-rss-finder-48.png",
-    "64": "icon/youtube-rss-finder-64.png",
-    "96": "icon/youtube-rss-finder-96.png",
-    "128": "icon/youtube-rss-finder-128.png",
-    "256": "icon/youtube-rss-finder-256.png",
-    "512": "icon/youtube-rss-finder-512.png",
-    "1024": "icon/youtube-rss-finder-1024.png"
+    "16": "icons/logo/youtube-rss-finder-16.png",
+    "24": "icons/logo/youtube-rss-finder-24.png",
+    "32": "icons/logo/youtube-rss-finder-32.png",
+    "48": "icons/logo/youtube-rss-finder-48.png",
+    "64": "icons/logo/youtube-rss-finder-64.png",
+    "96": "icons/logo/youtube-rss-finder-96.png",
+    "128": "icons/logo/youtube-rss-finder-128.png",
+    "256": "icons/logo/youtube-rss-finder-256.png",
+    "512": "icons/logo/youtube-rss-finder-512.png",
+    "1024": "icons/logo/youtube-rss-finder-1024.png"
   },
 
   "background": {