Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to close MIDI menu? #11

Open
tedmoore opened this issue Oct 4, 2022 · 4 comments
Open

How to close MIDI menu? #11

tedmoore opened this issue Oct 4, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@tedmoore
Copy link
Owner

tedmoore commented Oct 4, 2022

Right now there is no information on the screen telling the user how to close the MIDI menu when it is open!

hitting the m on the keyboard closes (and reopens) this menu. m is for "MIDI".

this info should be displayed on the screen somewhere!

@jeanbrazeau
Copy link
Collaborator

Perhaps something like this?

Screen Shot 2023-03-15 at 10 45 17 PM

@jeanbrazeau
Copy link
Collaborator

What are the necessary dimensions for the MIDI and Audio Interface Select windows?

@tedmoore
Copy link
Owner Author

thanks for these! having the midi selection be a switch isn't going to work because once it's on the part of the screen where the switch is will be greyed out.

But a button would make sense! that way there's a visual cue as to the fact that changing the MIDI device is possible. Then as you show it can have an [M] next to it so the user knows how to close it (we will put it on the pop-up window as well).

per the dimensions, right now it looks like this (below). the border is ugly (see the weird notches at the corners?). I could get rid of this by not doing the rounded corners, or a few other ways perhaps. the font renders kind of weird to me, so i might forgo the font that matches the skeuomorph and use a similar sans serif font.

I don't know if it makes sense to have rendered PNGs for using here. the list will need to be populated dynamically, so there wouldn't be much to pre-render? what thoughts do you @jeanbrazeau have about it?

Screen Shot 2023-03-21 at 11 19 56

@tedmoore tedmoore self-assigned this Mar 28, 2023
@tedmoore
Copy link
Owner Author

I've added this to the bottom as a quick fix for now, but eventually also having the button or whatever on the display itself will be good!

Screen Shot 2023-03-28 at 18 05 38

@tedmoore tedmoore assigned jeanbrazeau and unassigned tedmoore Mar 28, 2023
@tedmoore tedmoore added the enhancement New feature or request label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants