tkn taskrun delete --keep Doesn't Sort TaskRuns By Start Time Before Deleting

[danielhelfand]

Version and Operating System

tkn Version: v0.8.0

Expected Behavior

tkn tr delete --all --keep doesn't sort TaskRuns by start time before deleting them. The description for the command says that it Keep n least recent number of taskruns when deleting. As of now, the flag will delete TaskRuns that are sorted by name by default.

In general, a better deletion filtering method as described in #800 would probably make sense here, but, at the very least, this should be updated since this behavior is not expected by users.

Sorting should only be applied when --keep is specified. The way it is implemented for PipelineRuns, sorting takes place when --all is specified, which is unnecessary. This should be addressed for PipelineRuns as well so it only sorts when --keep is specified.

[waveywaves]

/assign