Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate webhook pods for resiliency #3386

Closed
imjasonh opened this issue Oct 14, 2020 · 2 comments · Fixed by #3391
Closed

Replicate webhook pods for resiliency #3386

imjasonh opened this issue Oct 14, 2020 · 2 comments · Fixed by #3391
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@imjasonh
Copy link
Member

Currently we run one replica of the webhook deployment, which makes it a single point of failure in the event of a node outage. The job doesn't do anything that requires running as a single replica, so we should investigate running multiple replicas.

We can crib from Knative Serving, which configures:

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 14, 2020
@imjasonh imjasonh added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Oct 14, 2020
@afrittoli
Copy link
Member

Thanks for this.
I think the pod anti-affinity will also mean that we will have one pod in case of a single-node cluster, which would be perfect as I'd like to preserve the smallest possible footprint for dev / test scenarios.

@raballew
Copy link
Contributor

Awesome idea! This is not only true for a node outage but also heavy load scenarios for the event listeners. In one of our production environments we faced situations, where the event listener got unresponsive because no auto scaling was in place and too many requests were send to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants