Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Tasks: Disallow use of Conditions #3592

Closed
GregDritschler opened this issue Dec 3, 2020 · 1 comment · Fixed by #3601
Closed

Custom Tasks: Disallow use of Conditions #3592

GregDritschler opened this issue Dec 3, 2020 · 1 comment · Fixed by #3601
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
Pipelines v0.20

Comments

@GregDritschler
Copy link
Contributor

Feature request

This is a follow-on to #3463.

Pipeline tasks that run custom tasks should not be allowed to also use Conditions. Conditions are deprecated and replaced by when. It does not make sense to invest in making Conditions work with Run.

Use case

This is needed to complete the work for https://github.com/tektoncd/community/blob/master/teps/0002-custom-tasks.md
@GregDritschler GregDritschler added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 3, 2020
@GregDritschler
Copy link
Contributor Author

I will work on this after #3463 is merged.

@GregDritschler GregDritschler mentioned this issue Dec 3, 2020
Merged
4 tasks
@vdemeester vdemeester added this to the Pipelines v0.20 milestone Dec 4, 2020
@GregDritschler GregDritschler mentioned this issue Dec 4, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
Pipelines v0.20
Development

Successfully merging a pull request may close this issue.

Do not allow use of deprecated Conditions with custom tasks GregDritschler/pipeline
2 participants
@vdemeester @GregDritschler