Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup Issues #1656

Closed
EricSch opened this issue Jul 10, 2018 · 3 comments
Closed

Rollup Issues #1656

EricSch opened this issue Jul 10, 2018 · 3 comments

Comments

@EricSch
Copy link

EricSch commented Jul 10, 2018

I'm submitting a...

  • Suggestion / Bug

Current behavior

I'm trying to optimize my code. So I changed like recommended an Angular Compiler options:
From "annotationsAs": "decorators" to the Default Settings "static fields". Since then rollup throws errors. The problem is with exported interfaces like "FileRestrictions" in @progress/kendo-angular-upload or "DateFormatOptions" in @progress/kendo-angular-intl. Those files are after compilation empty and rollup can't handle them correctly.
I'm aware it's more an Typescript compilation or rollup issue (see for ex. angular/angular-cli#2034 (comment)), but when those interfaces would exported as classes, the problem would also go away.

Expected behavior

rollup is able to do treeshaking correctly .

If there is any other solution, would happy to hear it.
Thank you

@tsvetomir
Copy link
Member

Replacing interfaces with classes seems like an overkill. It will result in larger bundles, as they must be retained in the final output.

Do you have a sample project that reproduces the error? I'd try turning on allowEmptyCodegenFiles
to see if it helps.

@EricSch
Copy link
Author

EricSch commented Jul 13, 2018

I'm trying to prepare something. Give me some time. Thanks

@tsvetomir
Copy link
Member

I'll close this issue as we don't plan immediate actions.
Feel free to reopen if more information becomes available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants