Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][PDF] GridPDFExport and TreeListPDFExport ReactDOM import errors in react 17 and 19 #2306

Closed
WissamProgress opened this issue Jun 13, 2024 · 2 comments
Assignees
Labels
Bug Item which indicates that something is not working KendoReact pkg:Grid pkg:PdfExport pkg:Treelist Regression Regression bug
Milestone

Comments

@WissamProgress
Copy link
Contributor

Related to #2286

I'm submitting a...

  • Regression report

Current behavior

After version 7.2.3, the GridPDFExport and TreeListPDFExport components are causing the following errors.
Screenshot 2024-06-13 at 17 05 12

In Next 15 RC with React 19 RC

../../packages/pdf/src/grid/provideSaveGridPDF.tsx
Attempted import error: 'render' is not exported from 'react-dom' (imported as 'ReactDOM').
../../packages/pdf/src/treelist/provideSaveTreeListPDF.tsx
Attempted import error: 'render' is not exported from 'react-dom' (imported as 'ReactDOM').

These component are using either ReactDOM.render or createRoot based on the React version.

Solution for React 17

Until this bug is fixed, you can use version 7.2.3 of @progress/kendo-react-pdf that does not import react-dom/client

Expected behavior

No errors in all React versions.

Minimal reproduction of the problem with instructions

Use the GridPDFExport or TreeListPDFExport component in React 17, or Next 15 RC.

@zdravkov
Copy link
Member

Fixed in the latest 'dev' npm version. It will also be in included in the offical version of KendoReact that is expected next week

@jamesryan-dev
Copy link

which version was this fixed in?

I've upgraded to React 18 now but getting this error when trying to use Kendo:

 ⨯ ./node_modules/@progress/kendo-react-pdf/KendoDrawingAdapter.mjs:10:1
Module not found: Package path ./server.js is not exported from package C:\Users\svc_appsrdp\Documents\Code\Journey\aadigital.journey.fe\node_modules\react-dom (see exports field in C:\Users\svc_appsrdp\Documents\Code\Journey\aadig
ital.journey.fe\node_modules\react-dom\package.json)

@elena-gancheva elena-gancheva added the Bug Item which indicates that something is not working label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Item which indicates that something is not working KendoReact pkg:Grid pkg:PdfExport pkg:Treelist Regression Regression bug
Projects
None yet
Development

No branches or pull requests

5 participants