redirect to your repo

[jtarchie]

Hi!

In short...

Is it alright to redirect people to your repo from mine?

I'd like to archive the github-pullrequest-resource in favor of yours. As it uses GraphQL, which solves a lot of issues.

We are fully feature complete, but I recognize that my resource started trying to do too much.

I'd also request that we update the concourse docs to reference your implementation rather than mine.

Cheers,

JT

[itsdalmo]

No problem at all, we are just happy to contribute what we can back to the Concourse community 🙌

Given that this resource is not a drop-in replacement for github-pullrequest-resource (e.g. parameters differ), perhaps we should provide a migration document to ease the transition?

[crstamps2]

I fully support this too. Its one of the main reasons I haven't really added in new features to the github-pullrequest-resource or taken the time to make the necessary tweaks to that resources CI and honestly even have started using this resource more. Using GraphQL is the better way to go.

FWIW, a few colleagues and I at my office have talked about the problems that the original PR resource has, and what to do about them. I have some learnings (of personal growth on this) that it's hard to become the core maintainer of a project on its way to archival, because I didn't fully understand some of the decisions that JT made early on.

Bottom line, I agree with JT on this. @jtarchie if you want me to, I can make the necessary changes on the original resource with deprecation warnings, and I can work with @itsdalmo on a migration strategy, etc.

[jtarchie]

@crstamps2, make it happen! Happy to help in any way I can, too.

There are no worries/concerns about ego, emotional attachment, etc. Our resource solved a problem at one point, but it no longer solves that issue effectively.

Better things are better. 👍 If something solves a problem better, use that thing.

🎉

[itsdalmo]

@crstamps2 - I've started listing out the differences between the two resources in #42 (rendered here), and figured that could be a starting-point for the "guide to users who want to migrate" - but I'm not sure how detailed we need/want to be? Thoughts?

[itsdalmo]

I'll close this issue since the redirect seems to be done after merges above 🙌

[jtarchie]

Sorry, I forgot to update this link.

Once the merge of the docs happened on concourse-ci.org, we waited a month, and then closed down the resource.

Thanks for everything.