Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Transfer-Encoding framing for cached and proxied responses #289

Closed
4 tasks done
krizhanovsky opened this issue Aug 19, 2022 · 0 comments · Fixed by #477
Closed
4 tasks done

Correct Transfer-Encoding framing for cached and proxied responses #289

krizhanovsky opened this issue Aug 19, 2022 · 0 comments · Fixed by #477
Assignees
Labels
enhancement New feature or request

Comments

@krizhanovsky
Copy link
Contributor

krizhanovsky commented Aug 19, 2022

With this commit we remove trailing CRLF for responses returned from the cache and stored with Transfer-Encoding: chunked. Need to test that we do not break message framing and really remove unnecessary CRLF.

  • General test verifying chunked encoding, including all the extensions allowed by the RFC
  • Test that Tempesta FW blocks responses with invalid encoding
  • Test framing and especially trailing part of the message for proxied and cached responses.
  • Test trailing headers

With tempesta-tech/tempesta#1418 we might remove Chunked-Encoding from cached responses at all, so the test issue probably must be adjusted. @const-t could you please update the issue after the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants