From 86bf9efa45b8dbc01987e6bc7ace923f7a8d7760 Mon Sep 17 00:00:00 2001 From: Dan Davison Date: Mon, 29 Jul 2024 13:25:13 -0400 Subject: [PATCH] Add rule code and edit signal warning --- src/Temporalio/Worker/WorkflowInstance.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Temporalio/Worker/WorkflowInstance.cs b/src/Temporalio/Worker/WorkflowInstance.cs index cdea823a..4a3acb27 100644 --- a/src/Temporalio/Worker/WorkflowInstance.cs +++ b/src/Temporalio/Worker/WorkflowInstance.cs @@ -2264,13 +2264,13 @@ private class Handlers : LinkedList LoggerMessage.Define( LogLevel.Warning, 0, - "Workflow {Id} finished while signal handlers are still running. This may " + + "[TMPRL1102] Workflow {Id} finished while signal handlers are still running. This may " + "have interrupted work that the signal handler was doing. You can wait for " + "all update and signal handlers to complete by using `await " + "Workflow.WaitConditionAsync(() => Workflow.AllHandlersFinished)`. " + "Alternatively, if both you and the clients sending the signal are okay with " + - "interrupting running handlers when the workflow finishes, and causing " + - "clients to receive errors, then you can disable this warning via the signal " + + "interrupting running handlers when the workflow finishes, " + + "then you can disable this warning via the signal " + "handler attribute: " + "`[WorkflowSignal(UnfinishedPolicy=HandlerUnfinishedPolicy.Abandon)]`. The " + "following signals were unfinished (and warnings were not disabled for their " + @@ -2280,7 +2280,7 @@ private class Handlers : LinkedList LoggerMessage.Define( LogLevel.Warning, 0, - "Workflow {Id} finished while update handlers are still running. This may " + + "[TMPRL1102] Workflow {Id} finished while update handlers are still running. This may " + "have interrupted work that the update handler was doing, and the client " + "that sent the update will receive a 'workflow execution already completed' " + "RpcException instead of the update result. You can wait for all update and " +