Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Stack trace on deadlock exception improvements #722

Open
cretz opened this issue Jan 8, 2025 · 0 comments
Open

[Feature Request] Stack trace on deadlock exception improvements #722

cretz opened this issue Jan 8, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Jan 8, 2025

Describe the solution you'd like

#626 added a stack traces from the deadlocking thread, but there are three improvements we need to make to make sure this is working properly:

  1. Make this also work for users that have opted out of sandboxing (if, as suspected reading the PR, it doesn't actually work already)
  2. Add a test to confirm the deadlock stack trace represents (couldn't see such a test in the PR)
  3. We append (no frames available) or (failed getting frames: {err}) when we couldn't capture the threads trace, but we should also add something like (no thread ID available) if the earlier condition occurs where for some reason we don't have a thread ID at all.
@cretz cretz added the enhancement New feature or request label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant