Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MsgInitializeMainnet simulation operation always fails #717

Closed
lumtis opened this issue Apr 13, 2022 · 2 comments · Fixed by #723
Closed

MsgInitializeMainnet simulation operation always fails #717

lumtis opened this issue Apr 13, 2022 · 2 comments · Fixed by #723
Assignees
@giunatale @aljo242
Labels
campaign Related to campaign module test Improve tests

Comments

@lumtis
Copy link
Contributor

lumtis commented Apr 13, 2022

initialize_mainnet operation in campaign module always fails independently from the chosen seed

GetCoordSimAccountWithCampaignID may have an issue when arg requireNoMainnetInitialize is set to true
@lumtis lumtis added test Improve tests campaign Related to campaign module labels Apr 13, 2022
@lumtis lumtis mentioned this issue Apr 13, 2022
Closed
@aljo242 aljo242 self-assigned this Apr 13, 2022
@giunatale
Copy link
Contributor

giunatale commented Apr 13, 2022 •
edited
Loading

Trying to increase the frequency by changing the weights seems to yield some successes. (setting both to 20 in module_simulation.go)

Screenshot 2022-04-13 at 17 30 19

I was noticing the same for msgEditCampaign where requireNoMainnetInitialized is set to false, so I think the assumption regarding requireNoMainnetInitialized is unlikely.

I am assuming what is actually happening is that coordinators for the campaigns selected are inactive or not found, for some reason (so the last leg of the method). Besides, the function is tested to be providing correct results, so the only thing I can think is influencing the simulation is state changes.

@lumtis
Copy link
Contributor Author

lumtis commented Apr 13, 2022

Ok, if we have a few ok then I would guess it is fine, we just need to increase the weight of the operation

@giunatale giunatale mentioned this issue Apr 13, 2022
Merged
@giunatale giunatale self-assigned this Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giunatale giunatale

@aljo242 aljo242

Labels
campaign Related to campaign module test Improve tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(campaign): update defaultWeightMsgInitializeMainnet tendermint/spn
3 participants
@lumtis @giunatale @aljo242