Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling MsgAddVestingOptions message #774

Closed
lumtis opened this issue May 9, 2022 · 0 comments · Fixed by #788
Closed

Disabling MsgAddVestingOptions message #774

lumtis opened this issue May 9, 2022 · 0 comments · Fixed by #788
Assignees
Labels
campaign Related to campaign module

Comments

@lumtis
Copy link
Contributor

lumtis commented May 9, 2022

MsgAddVestingOptions allows the coordinator to provide shares to an account for a mainnet where the reflected balance will have vesting option.

However, with special allocation, we may have a more generic way to allow coordinator to create vesting options: #767
With GenesisDistribution allocation, the coordinator provides shares allocation for genesis distribution. Accounts are defined in a custom genesis, in this custom genesis, the accounts can acquire vesting options

I would consider disabling MsgAddVestingOptions for the following reason:

  • Special allocation is more flexible, we only support Delayed Vesting options in MsgAddVestingOptions while any kind of vesting option like PeriodicVesting can already be provided through special allocation
  • Supporting this message adds a burden to the genesis generation because we would need to handle the case where a vesting option is defined for an account in the custom genesis with special allocation and another vesting option is defined with MsgAddVestingOptions => how to combine both vesting options during genesis generation?

I would not remove entirely the feature from the codebase because:

  • In the future we might consider implementing Vesting Vouchers, vouchers reflecting shares with vesting options. At this point it would make sense to address the issue above for the client with vesting options defined several times
@lumtis lumtis added the campaign Related to campaign module label May 9, 2022
@lumtis lumtis self-assigned this May 11, 2022
@lumtis lumtis changed the title Proposition: Disabling MsgAddVestingOptions message Disabling MsgAddVestingOptions message May 11, 2022
@lumtis lumtis linked a pull request May 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
campaign Related to campaign module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant