Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app.go simplify import names for modules #876

Closed
lumtis opened this issue Jun 20, 2022 · 0 comments · Fixed by #889
Closed

app.go simplify import names for modules #876

lumtis opened this issue Jun 20, 2022 · 0 comments · Fixed by #889
Assignees
@aljo242

Comments

@lumtis
Copy link
Contributor

lumtis commented Jun 20, 2022

We have the following imports for our modules:

launchmodule "github.com/tendermint/spn/x/launch"
launchmodulekeeper "github.com/tendermint/spn/x/launch/keeper"
launchmoduletypes "github.com/tendermint/spn/x/launch/types"

CLI automatically add module in the import name to avoid collision with variables for generic names

We should remove this suffix for cleaniness

launch "github.com/tendermint/spn/x/launch"
launchkeeper "github.com/tendermint/spn/x/launch/keeper"
launchtypes "github.com/tendermint/spn/x/launch/types"
@aljo242 aljo242 self-assigned this Jul 8, 2022
@lumtis lumtis linked a pull request Jul 11, 2022 that will close this issue
chore: fix app import names #889
Merged
@lumtis lumtis closed this as completed Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aljo242 aljo242

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix app import names tendermint/spn
2 participants
@lumtis @aljo242