Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] PeekEpochSeigniorage has been computing seigniorage reversely #195

Closed
yun-yeo opened this issue Jul 5, 2019 · 0 comments · Fixed by #231
Closed

[BUG] PeekEpochSeigniorage has been computing seigniorage reversely #195

yun-yeo opened this issue Jul 5, 2019 · 0 comments · Fixed by #231
Assignees
@yun-yeo
Labels
bug Something isn't working must Mustfix for target release.

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Jul 5, 2019 •
edited
Loading

Describe the bug
In market keeper, PeekEpochSeigniorage computes seigniorage by subtracting previous issuance from current issuance. When luna is swapped to terra, seignorage should increase however current implementation is reverse.

It should be patched before 12 weeks from the genesis time of columbus-2

To Reproduce

  1. Change prohibition period to zero
  2. Swap luna to sdr.
  3. Peek seigniorage of next epoch.

Context & versions
core-v0.2.x

(if applicable) suggested solution
Change PeekEpochSeigniorage to compute seigniorage by subtracting current issuance from previous issuance.
@yun-yeo yun-yeo added bug Something isn't working must Mustfix for target release. labels Jul 5, 2019
@yun-yeo yun-yeo self-assigned this Jul 5, 2019
@yun-yeo yun-yeo mentioned this issue Jul 5, 2019
Merged
8 tasks
This was referenced Sep 3, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yun-yeo yun-yeo

Labels
bug Something isn't working must Mustfix for target release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to cosmos-v0.37.0 terra-money/classic-core
1 participant
@yun-yeo