Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add tx-gas-hard-limit flag to prevent spamming attack #460

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Mar 17, 2021

Summary of changes

To prevent spamming attack,

We added new flag tx-gas-hard-limit to terrad cmd.

Default tx-gas-hard-limit is 30,000,000.
and node operators can set in any other value.

This change is only applied to mempool operation (check tx), so can be applied anytime without consensus failure

$ terrad start --tx-gas-hard-limit 10000000

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo requested a review from hanjukim March 17, 2021 03:23
@yun-yeo yun-yeo merged commit 6d19120 into master Mar 17, 2021
@yun-yeo yun-yeo deleted the feature/spamming-protection branch March 17, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant