fix: Update dynamic lookup logic to support lazy evaluation #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
commented
Jun 23, 2022
| @@ -176,7 +177,8 @@ resource "aws_dms_endpoint" "this" { | |||
|
|
|||
| # https://docs.aws.amazon.com/dms/latest/userguide/CHAP_Target.Elasticsearch.html | |||
| dynamic "elasticsearch_settings" { | |||
| for_each = try([each.value.elasticsearch_settings], []) | |||
There was a problem hiding this comment.
try() was great, but I guess theres still a place for lookup() too 😬
antonbabenko
approved these changes
Jun 23, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Jun 23, 2022
### [1.5.2](v1.5.1...v1.5.2) (2022-06-23) ### Bug Fixes * Update dynamic lookup logic to support lazy evaluation ([#19](#19)) ([8fb0daa](8fb0daa))
|
This PR is included in version 1.5.2 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
kinesis_settings must be set when engine_name = "kinesis"With kinesis_settings Value Set #18Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request