feat: Make repl config timeouts configurable #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR exposes the timeouts block for the aws_dms_replication_config resource
Adam262
changed the title
Adam262
force-pushed
the
feat/configure-dms-config-timeouts
branch
from
08bbd5e to
c110502
Compare
antonbabenko
requested changes
Nov 18, 2024
main.tf
Outdated
| @@ -432,6 +432,12 @@ resource "aws_dms_replication_config" "this" { | |||
| } | |||
|
|
|||
| tags = merge(var.tags, try(each.value.tags, {})) | |||
|
|
|||
| timeouts { | |||
| create = var.repl_config_timeouts.create | |||
There was a problem hiding this comment.
Please make this block and variable like in aws_dms_replication_instance resource:
Suggested change
| create = var.repl_config_timeouts.create | |
| create = try(var.repl_config_timeouts.create, null) |
Adam262
force-pushed
the
feat/configure-dms-config-timeouts
branch
from
c110502 to
e58c043
Compare
antonbabenko
approved these changes
Nov 18, 2024
antonbabenko
merged commit 491f197
into
terraform-aws-modules:master
14 of 16 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Nov 18, 2024
|
This PR is included in version 2.4.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the timeouts block for the aws_dms_replication_config Terraform resource
Motivation and Context
In my team's work, we have found that Serverless Replications can take longer than the resource's default 60m timeout to become healthy. So we end up in a bad Terraform state, where TF creates the Replication, times out creating the config and leaves the resource in a tainted state that we need to clean up. Ideally, this change will allow TF to fully create Replication Config resources without timing out.
Breaking Changes
Changes are optional and non-breaking
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request