Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update policie for External Secrets 0.12.1 #26

Conversation

rastut
Copy link
Contributor

@rastut rastut commented Dec 27, 2024

Description

This pull request includes a change to the IAM policy document for external secrets in the modules/iam-role-for-service-accounts-eks/policies.tf file. The change adds a new permission to the policy.

  • Added secretsmanager:BatchGetSecretValue permission to the data "aws_iam_policy_document" "external_secrets" block to allow batch retrieval of secret values.

Motivation and Context

External Secrets 0.12.1 introduces the use of BulkFetch to fetch secrets from the AWS Secret Manager.
https://github.com/external-secrets/external-secrets/releases
https://github.com/external-secrets/external-secrets/blob/main/docs/provider/aws-secrets-manager.md?plain=1

Breaking Changes

No breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit b63aaf1 into terraform-aws-modules:master Dec 27, 2024
8 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 27, 2024
## [1.8.0](v1.7.0...v1.8.0) (2024-12-27)

### Features

* Update policie for External Secrets 0.12.1 ([#26](#26)) ([b63aaf1](b63aaf1))
@antonbabenko
Copy link
Member

This PR is included in version 1.8.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants