Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nitro enclave support for EKS #1185

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

spkane
Copy link
Contributor

@spkane spkane commented Jan 15, 2021

PR o'clock

Description

Make it possible to enable nitro enclave support in EKS.

Should resolve (after testing in complete):
Resolves #1181
Resolves #1182

Checklist

@spkane spkane marked this pull request as draft January 15, 2021 01:09
@spkane spkane changed the title Add enclave support improvement: Add nitro enclave support for EKS Jan 15, 2021
@spkane spkane marked this pull request as ready for review January 20, 2021 17:16
@spkane
Copy link
Contributor Author

spkane commented Jan 20, 2021

This appears to be usable as is. There might be some improvements that can be made but this makes it possible to enable this in a launch template and get nodes with full support for Nitro enclaves.

@spkane
Copy link
Contributor Author

spkane commented Jan 28, 2021

@barryib Who is the right person to review and merge this?

@barryib barryib changed the title improvement: Add nitro enclave support for EKS feat: Add nitro enclave support for EKS Jan 28, 2021
@barryib barryib merged commit 4fc609b into terraform-aws-modules:master Jan 28, 2021
@barryib
Copy link
Member

barryib commented Jan 28, 2021

Thanks @spkane for your contribution.

@spkane
Copy link
Contributor Author

spkane commented Jan 28, 2021

Thanks @spkane for your contribution.

And thank you @barryib , for pushing it through. Much appreciated!

@spkane spkane deleted the add-enclave-support branch January 28, 2021 22:47
ArchiFleKs pushed a commit to ArchiFleKs/terraform-aws-eks that referenced this pull request Apr 16, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for Nitro Enclaves Support nitro enclaves in launch template
2 participants