Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add node_iam_role_arns local variable to check for Windows platform on EKS managed nodegroups #2477

Merged
merged 2 commits into from
Aug 3, 2023
Merged

feat: Add node_iam_role_arns local variable to check for Windows platform on EKS managed nodegroups #2477

merged 2 commits into from
Aug 3, 2023

Conversation

aamoctz
Copy link
Contributor

@aamoctz aamoctz commented Feb 15, 2023 •
edited
Loading

Description

This change adds additional checks for platform == "windows" on both local.node_iam_role_arns_non_windows and local.node_iam_role_arns_windows.

The additional validation in local.node_iam_role_arns_windows ensures that the correct configurations are added to aws-auth.

The additiional validation in local.node_iam_role_arns_non_windows ensures that terraform does not also create an extra incorrect entry in aws-auth for the node group.

To support this change, the eks_managed_node_group module has a new output (platform)

Motivation and Context

Resolves the issue described in this comment from #2350

Breaking Changes

No breaking changes found during my testing.

How Has This Been Tested?

  • [] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@aamoctz aamoctz changed the title Update node_iam_role_arns locals to check for Windows Managed Node Groups fix: Update node_iam_role_arns locals to check for Windows Managed Node Groups Feb 15, 2023
@hp197
Copy link

hp197 commented Feb 16, 2023

👍

@noamgreen
Copy link

can someone approve this :-)

@noamgreen noamgreen mentioned this pull request Feb 28, 2023
Closed
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 31, 2023
@hp197
Copy link

hp197 commented Mar 31, 2023

bump

@github-actions github-actions bot removed the stale label Apr 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label May 1, 2023
@aamoctz
Copy link
Contributor Author

aamoctz commented May 5, 2023

bump

@github-actions github-actions bot removed the stale label May 6, 2023
@mcmagi
Copy link

mcmagi commented May 18, 2023

I would also greatly appreciate a review of this. Thanks!

@jxn
Copy link

jxn commented May 23, 2023

I've nearly submitted this exact same code in a different PR today. Even with today's master, the changes are the same. It would be great to get this reviewed and pulled in so managed windows node groups can be functional instances.

@saedx1
Copy link

saedx1 commented May 23, 2023

Can we please get this reviewed and merged? It's really needed!

@bryantbiggs
Copy link
Member

how has this been tested and validated?

@mlschindler
Copy link

+1 this PR would benefit us greatly

@aamoctz
Copy link
Contributor Author

aamoctz commented Jun 12, 2023

how has this been tested and validated?

PR was tested using the eks_managed_node_group example module, with some modifications to use existing VPC related resources since those are managed elsewhere within my org. I do not have access to a sandbox account so that's the closest I can get.

@sean-redmond
Copy link

This looks good in some limited testing, given the problems this is currently causing I think it should be pulled in.

@sankalpkale88
Copy link

+1 Can we please get this merged ?

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jul 23, 2023
@bryantbiggs bryantbiggs added on hold and removed stale labels Jul 23, 2023
@sean-redmond
Copy link

Would be really nice to see this merged.

@kirillowen
Copy link

+1 Would be great to see this merged.

@bryantbiggs bryantbiggs changed the title fix: Update node_iam_role_arns locals to check for Windows Managed Node Groups feat: Add node_iam_role_arns local variable to check for Windows platform on EKS managed nodegroups Aug 3, 2023
bryantbiggs
bryantbiggs approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, this won't function the same as AL2 and Bottlerocket nodes (custom launch template and injection of user data) but hopefully it unblocks some folks

@bryantbiggs bryantbiggs merged commit adb47f4 into terraform-aws-modules:master Aug 3, 2023
antonbabenko pushed a commit that referenced this pull request Aug 3, 2023
@semantic-release-bot
chore(release): version 19.16.0 [skip ci]
666603b 
## [19.16.0](v19.15.4...v19.16.0) (2023-08-03)

### Features

* Add `node_iam_role_arns` local variable to check for Windows platform on EKS managed nodegroups ([#2477](#2477)) ([adb47f4](adb47f4))
@antonbabenko
Copy link
Member

This PR is included in version 19.16.0 🎉

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.