Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Create an endpoint group only when a definition is provided under the endpoint_group argument #14

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: Create an endpoint group only when a definition is provided under the endpoint_group argument #14

merged 1 commit into from
Apr 9, 2024

Conversation

alex-bako
Copy link
Contributor

@alex-bako alex-bako commented Apr 9, 2024 •
edited by bryantbiggs
Loading

Create an endpoint group only, when the listener's endpoint group is not empty

Description

  • Create an endpoint group only, when the listener's endpoint group is not empty

Motivation and Context

Breaking Changes

  • No breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request
  • I have tested and validated these changes using the same setup I mentioned in the issue. I created an accelerator resource, and then I created a listener resource

fix: endpoint group creation
02214dd 
Create an endpoint group only, when the listener's
endpoint group is not empty
@alex-bako alex-bako changed the title fix: endpoint group creation Create endpoint group only when it is defined in the input variables Apr 9, 2024
@alex-bako alex-bako changed the title Create endpoint group only when it is defined in the input variables Create endpoint group only when it is defined in the listener input variable Apr 9, 2024
@alex-bako alex-bako changed the title Create endpoint group only when it is defined in the listener input variable fix: Endpoint group creation Apr 9, 2024
@bryantbiggs bryantbiggs changed the title fix: Endpoint group creation fix: Create an endpoint group only when a definition is provided under the endpoint_group argument Apr 9, 2024
bryantbiggs
bryantbiggs approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thank you!

@bryantbiggs bryantbiggs merged commit 1ea3d52 into terraform-aws-modules:master Apr 9, 2024
8 of 11 checks passed
antonbabenko pushed a commit that referenced this pull request Apr 9, 2024
@semantic-release-bot
chore(release): version 2.2.2 [skip ci]
23ef3ba 
## [2.2.2](v2.2.1...v2.2.2) (2024-04-09)

### Bug Fixes

* endpoint group creation ([#14](#14)) ([1ea3d52](1ea3d52))
@antonbabenko
Copy link
Member

This PR is included in version 2.2.2 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endpoint Group gets created even when the listener's endpoint_group is not defined
3 participants
@alex-bako @antonbabenko @bryantbiggs