feat: Allow to customizable instance settings #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rds-aurora into feature/extend-pr132
- Make publicly_accessible per-instance setting
antonbabenko
changed the title
|
Good timing @LAKostis 👍 I was reviewing the #132 by @kostyaplis and then your PR came. Thanks to both of you! v2.26.0 has been just released. |
This was referenced Sep 22, 2020
tomasbackman
pushed a commit
to qapital/terraform-aws-rds-aurora
that referenced
this pull request
Nov 16, 2020
This was referenced Mar 13, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend PR #132 to allow publicly setting can be set per instance
Motivation and Context
Sometimes cluster instances can be hidden from public access (let's say writer is private but readers are not), I've combined changes from PR #132 and extend them to control publicly_accessible setting per instance.
Breaking Changes
Doesn't change current setup, old configuration syntax still supported.
How Has This Been Tested?
This code from provided example works:
instances_parameters = [ // List index should be equal toreplica_count// Omitted keys replaced by module defaults { instance_type = "db.r5.2xlarge" publicly_accessible = true }, { instance_type = "db.r5.2xlarge" }, { instance_name = "reporting" instance_type = "db.r5.large" instance_promotion_tier = 15 } ]