-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for ca_cert_identifier option #83
add support for ca_cert_identifier option #83
Conversation
v1.20.0 has been just released. Thank you @koneru9999 ! |
is this integrated for the Terraform 0.11 branch too? |
Yes, Terraform 0.11 users should use |
It seems like not working our case we're facing the error:
using the v1.20.0 for the terraform 0.11, this makes no sense, new variable with default...
|
This reverts commit 0411b1a.
@antonbabenko My apologies for the PR and wasting your valuable time. I could have checked it more properly. 😞 |
@koneru9999 That's ok, it happens sometimes. For me, it means that the simplest automatic checks would catch this error. I probably need to prioritize those a bit more. :) |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This PR adds the option to set the ca_cert_identifier
As the current CA is expiring 5th March 2020 i need to update my clusters to use the new CA before that. The default is currently set to the old one to not break any existing installations.
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL-certificate-rotation.html
Terraform has recently added support for this. hashicorp/terraform-provider-aws#10490