Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally pass additional networks to the instance template #117

Conversation

pwillis-eiq
Copy link
Contributor

@pwillis-eiq pwillis-eiq commented Oct 20, 2022

This passes through the additional_networks variable from https://github.com/terraform-google-modules/terraform-google-vm/tree/master/modules/instance_template . This allows using this module to build a bastion with more than one network interface.

Also passing in optional service_account_email and metadata as I'm using those too, to pass a pre-existing service account, and to pass additional instance metadata.

@pwillis-eiq pwillis-eiq requested a review from a team as a code owner October 20, 2022 22:42
@google-cla
Copy link

google-cla bot commented Oct 20, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@comment-bot-dev
Copy link

@pwillis-eiq
Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pwillis-eiq

@bharathkkb bharathkkb merged commit 5c601c9 into terraform-google-modules:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants