Fixes the issue with modified time affecting zip contents #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archive contains file header that contains file modification time, whenever this time changes (ie. git checkout) archive checksum changes event if content is the same. There is no way to know what the mtime was so we always set it to zero.
paultyng
changed the title
jbardin
suggested changes
Mar 23, 2018
archive/zip_archiver_test.go
Outdated
| func TestZipArchiver_FileModified(t *testing.T) { | ||
| const ( | ||
| zipFilePath = "archive-file.zip" | ||
| toZipPath = "./test-fixtures/test-file.txt" |
There was a problem hiding this comment.
We need to use filepath for all paths. I know there are a tin of broken tests as it is, but I would like to get testing to work on windows someday.
jbardin
approved these changes
Mar 23, 2018
This was referenced Mar 23, 2018
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.