resource/aws_lambda_permission: Add support for statement_id_prefix #2743
Conversation
jen20
added
the
enhancement
ColinHebert
changed the title
radeksimko
added
the
service/lambda
radeksimko
changed the title
There was a problem hiding this comment.
Hi @ColinHebert
Thanks for the work here! Just left a thing to update, because I'm assuming the related test will fail.
Once fixed, can you ensure it's ok running tests? thanks!
| } | ||
|
|
||
| resource "aws_iam_role" "iam_for_lambda" { | ||
| name = "%s" |
There was a problem hiding this comment.
I'm assuming that this will be failing as this is not being replaced
There was a problem hiding this comment.
Indeed:
--- FAIL: TestAccAWSLambdaPermission_withStatementIdPrefix (1.28s)
testing.go:503: Step 0 error: Configuration is invalid.
Warnings: []string(nil)
Errors: []string{"aws_iam_role.iam_for_lambda: \"name\" must match [\\w+=,.@-]"}
| @@ -112,12 +112,13 @@ EOF | |||
|
|
|||
| ## Argument Reference | |||
|
|
|||
| * `statement_id` - (Optional) A unique statement identifier. By default generated by Terraform. | |||
| * `statement_id_prefix` - (Optional) A unique statement identifier. Conflicts with `statement_id`. | |||
There was a problem hiding this comment.
Can you put that after qualifier so that it is alphabetically ordered?
|
I will finish the feedback here and get this merged 👍 |
|
This has been released in version 1.17.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #114