[WIP] network_acl_rule: conflicts: cidr_block <-> ipv6_cidr_block

[Dominik-K]

Tried setting it on resource_aws_network_acl.go as well, but:

1 error(s) occurred:

* resource aws_network_acl: cidr_block: ConflictsWith references unknown attribute (ipv6_cidr_block)

[bflad]

LGTM as this introduces plan-time validation to prevent apply-time errors like these:

* aws_network_acl_rule.test: Error Creating Network Acl Rule: InvalidParameterCombination: The parameter cidrBlock cannot be used with the parameter ipv6CidrBlock

Until Terraform 0.12 introduces nullable arguments, downstream modules can create two separate rules guarded by count, depending on which type is being passed in.

5 tests passed (all tests)
=== RUN   TestAccAWSNetworkAclRule_ipv6
--- PASS: TestAccAWSNetworkAclRule_ipv6 (9.64s)
=== RUN   TestAccAWSNetworkAclRule_allProtocol
--- PASS: TestAccAWSNetworkAclRule_allProtocol (14.80s)
=== RUN   TestAccAWSNetworkAclRule_missingParam
--- PASS: TestAccAWSNetworkAclRule_missingParam (16.46s)
=== RUN   TestAccAWSNetworkAclRule_deleteRule
--- PASS: TestAccAWSNetworkAclRule_deleteRule (27.00s)
=== RUN   TestAccAWSNetworkAclRule_basic
--- PASS: TestAccAWSNetworkAclRule_basic (27.01s)

[bflad]

This has been released in version 1.26.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!