Make EventSourceMapping.starting_position optional. #5024

CyrusNajmabadi · 2018-06-28T22:35:52Z

Amazon recently made it possible to have SQS events trigger Lambdas. See: https://aws.amazon.com/blogs/aws/aws-lambda-adds-amazon-simple-queue-service-to-supported-event-sources/ for more details.

As part of this they specifically utilize CreateSourceEventMapping to describe the mapping between SQS and Lambda: https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html

However, as part of this, they changed the StartingPosition message property from required to optional. You can see that it was previous required here: https://web.archive.org/web/20171222204154/https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-eventsourcemapping.html

StartingPosition
    The position in the stream where Lambda starts reading. For valid values, see CreateEventSourceMapping in the AWS Lambda Developer Guide.
    Required: Yes
    Type: String
    Update requires: Replacement

But now is optional in the current set of docs:

StartingPosition
    The position in the stream where Lambda starts reading. For valid values, see CreateEventSourceMapping in the AWS Lambda Developer Guide.
    Required: No
    Type: String
    Update requires: Replacement

Unfortunately, this makes is (afaict) impossible to use terraform to configure this EventSourceMapping. If i leave out the starting_position property, terraform complains with:

Plan apply failed:
Error creating Lambda event source mapping: ValidationException: 1 validation error detected: Value '' at 'startingPosition' failed to satisfy constraint: Member must satisfy enum value set: [LATEST, AT_TIMESTAMP, TRIM_HORIZON]

However, if i supply any of those, AWS itself errors out with:

Plan apply failed: 
Error creating Lambda event source mapping: InvalidParameterValueException: StartingPosition is not valid for SQS event sources.

This PR attempts to rectify things by making this property optional to match current AWS expectations.

Fixes #5025

Output from acceptance testing:

cyrusn@matebunty ~/go/src/github.com/terraform-providers/terraform-provider-aws[pulumi-master ≡]> make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSAvailabilityZones -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSAvailabilityZones_basic
--- PASS: TestAccAWSAvailabilityZones_basic (28.19s)
=== RUN   TestAccAWSAvailabilityZones_stateFilter
--- PASS: TestAccAWSAvailabilityZones_stateFilter (29.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	57.462s```

CyrusNajmabadi · 2018-06-28T22:53:54Z

Running acceptance testing now.

CyrusNajmabadi · 2018-06-28T23:39:47Z

@bflad, i've seen you help out with a lot of PRS. Could you let me know if i've done this right, and if there's anything else i need to do? Thanks!

bflad · 2018-06-29T13:01:58Z

Can you please add an acceptance test that shows the resource working when you skip adding this argument and the output of make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaEventSourceMapping'?

CyrusNajmabadi · 2018-06-29T21:33:10Z

@bflad Done. results are:

cyrusn@matebunty ~/go/src/github.com/terraform-providers/terraform-provider-aws[patch-1 ↑ +0 ~2 -0]> make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaEventSourceMapping'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLambdaEventSourceMapping -timeout 120m
=== RUN   TestAccAWSLambdaEventSourceMapping_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_basic (105.09s)
=== RUN   TestAccAWSLambdaEventSourceMapping_sqsBasic
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsBasic (92.92s)
=== RUN   TestAccAWSLambdaEventSourceMapping_importBasic
--- PASS: TestAccAWSLambdaEventSourceMapping_importBasic (92.26s)
=== RUN   TestAccAWSLambdaEventSourceMapping_disappears
--- PASS: TestAccAWSLambdaEventSourceMapping_disappears (89.96s)
=== RUN   TestAccAWSLambdaEventSourceMapping_sqsDisappears
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (124.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	504.291s

Note: it was good to write these tests. They revealed the need to add retry logic here as event mapping for sqs events can actually take quite a while to transition between states. This was fine locally, but revealed problems in testing when the tests wanted to create/update/delete in rapid succession.

Amazon recently made it possible to have SQS events trigger Lambdas. See: https://aws.amazon.com/blogs/aws/aws-lambda-adds-amazon-simple-queue-service-to-supported-event-sources/ for more details. As part of this they specifically utilize CreateSourceEventMapping to describe the mapping between SQS and Lambda: https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html *However*, as part of this, they changed the StartingPosition message property from required to optional. You can see that it was previous required here: https://web.archive.org/web/20171222204154/https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-eventsourcemapping.html ``` StartingPosition The position in the stream where Lambda starts reading. For valid values, see CreateEventSourceMapping in the AWS Lambda Developer Guide. Required: Yes Type: String Update requires: Replacement ``` But now is optional in the current set of docs: ``` StartingPosition The position in the stream where Lambda starts reading. For valid values, see CreateEventSourceMapping in the AWS Lambda Developer Guide. Required: No Type: String Update requires: Replacement ``` Unfortunately, this makes is (afaict) impossible to use terraform to configure this EventSourceMapping. If i leave out the starting_position property, terraform complains with: ``` Plan apply failed: Error creating Lambda event source mapping: ValidationException: 1 validation error detected: Value '' at 'startingPosition' failed to satisfy constraint: Member must satisfy enum value set: [LATEST, AT_TIMESTAMP, TRIM_HORIZON] ``` However, if i supply any of those, AWS itself errors out with: ``` Plan apply failed: Error creating Lambda event source mapping: InvalidParameterValueException: StartingPosition is not valid for SQS event sources. ``` This PR attempts to rectify things by making this property optional to match current AWS expectations.

flosell · 2018-07-01T04:38:49Z

Just tried this PR on a toy project, can confirm that it works fine!

Thanks @CyrusNajmabadi, this will be a great help on my current project!
@bflad hope we can get this merged soon

ryandeivert · 2018-07-01T17:13:58Z

hey @CyrusNajmabadi - I could be wrong here, buit I'm fairly certain the batch_size default value for this resource should also be removed now.

The default of 100 worked well for Kinesis and DynamoDB streams. However, the default for SQS (assigned by aws) is actually 1, while the max is 10. It's not incredibly obvious from the docs, but you can see this documented within the SDK here.

This means that if someone omits the batch_size argument when configuring an SQS event source mapping, a validation error will likely occur with aws.

CyrusNajmabadi · 2018-07-02T08:10:48Z

@ryandeivert You are correct. However, i'm not sure the right thing to do here. If we remove te batch_size default, won't that break existing customers of terraform who use this for Kinesis/Dynamo, but do not provide a size?

This means that if someone omits the batch_size argument when configuring an SQS event source mapping, a validation error will likely occur with aws.

That's true. But then it's fixable by the user.

@ryandeivert @bflad I don't know enough about terraform to know what the right thing is to do here. Can either of you shed light on the preferred course of action? Thanks!

CyrusNajmabadi · 2018-07-02T08:11:35Z

Just tried this PR on a toy project, can confirm that it works fine!

Great! I also have validated this myself. But i'm glad to get secondary validation to ensure that there's nothing special about my setup! Thanks much @flosell !

CyrusNajmabadi · 2018-07-02T09:18:26Z

@ryandeivert Looking at the AWS docs some more, it looks like what you're saying should be safe. Their docs mention:

+	// with all the retrieved records. The default for Amazon Kinesis and Amazon
+	// DynamoDB is 100 records. For SQS, the default is 1.
 	BatchSize *int64 `min:"1" type:"integer"`

So it sounds like we can simply remove the default for BatchSize. Anyone who is using the default today will be fine, since it will continue to be 100 if left out from the call to the actual AWS SDK.

It no longer applies as the sqs mapping default is 10.

CyrusNajmabadi · 2018-07-02T09:57:12Z

I've made the change to the default, and i've rerun tests:

cyrusn@matebunty ~/go/src/github.com/terraform-providers/terraform-provider-aws[patch-1 ≡]> make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaEventSourceMapping'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLambdaEventSourceMapping -timeout 120m
=== RUN   TestAccAWSLambdaEventSourceMapping_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_basic (113.63s)
=== RUN   TestAccAWSLambdaEventSourceMapping_sqsBasic
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsBasic (100.05s)
=== RUN   TestAccAWSLambdaEventSourceMapping_importBasic
--- PASS: TestAccAWSLambdaEventSourceMapping_importBasic (96.89s)
=== RUN   TestAccAWSLambdaEventSourceMapping_disappears
--- PASS: TestAccAWSLambdaEventSourceMapping_disappears (92.24s)
=== RUN   TestAccAWSLambdaEventSourceMapping_sqsDisappears
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (128.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	531.044s

bflad · 2018-07-02T14:01:00Z

aws/resource_aws_lambda_event_source_mapping_test.go

-		depends_on = ["aws_iam_policy_attachment.policy_attachment_for_role"]
-		function_name = "${aws_lambda_function.lambda_function_test_create.arn}"
-		starting_position = "TRIM_HORIZON"
+    batch_size = 100


Given that batch_size had its default removed, it should also be removed from the existing test configurations and separately tested in its own acceptance test and test configuration.

In the cases where you remove it from the test configurations, I have a hunch you will start seeing test failures with the resource wanting to change it since the API likely always returns a value, but its not specified in the configuration. e.g. batch_size: "100" => "".

If that is the case, we need to add a DiffSuppressFunc to the batch_size attribute.

@bflad Can you expand on this a bit. I went to take a look. but i think there's a small snag. If i'm understanding right, we would want to supress things if old was 100, and new was <empty>, and this was a Kinesis or DynamoDB case.

However, the problem i'm having is figuring out how to tell if this is Kinesis or DynamoDB. event_source_arn doesn't really tell me this, as it's just an arbitrary ARN. Or is the intent that i would somehow get the true value here and try to 'sniff' it to tell what was going on?

Sorry, i've looked around a bit to see if i can figure out the right way to address this. But it was not clear to me. So any help would def be appreciated. Thanks!

Luckily the ARN has the service name in it 😄 Does something like this do the trick?

DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool { eventSourceARN, err := arn.Parse(d.Get("event_source_arn").(string)) if err != nil { return false } switch eventSourceARN.Service { case dynamodb.ServiceID: if old == "100" && new == "" { return true } case kinesis.ServiceID: if old == "100" && new == "" { return true } case sqs.ServiceID: if old == "1" && new == "" { return true } } return false },

Slightly cleaner version:

DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool { if new != "" { return false } eventSourceARN, err := arn.Parse(d.Get("event_source_arn").(string)) if err != nil { return false } if eventSourceARN.Service == dynamodb.ServiceID && old == "100" { return true } if eventSourceARN.Service == kinesis.ServiceID && old == "100" { return true } if eventSourceARN.Service == sqs.ServiceID && old == "1" { return true } return false },

could have also done similar with multiple case statements:

DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool { eventSourceARN, err := arn.Parse(d.Get("event_source_arn").(string)) if err != nil { return false } switch eventSourceARN.Service { case dynamodb.ServiceID, kinesis.ServiceID: if old == "100" && new == "" { return true } case sqs.ServiceID: if old == "1" && new == "" { return true } } return false },

Thanks guys. That looks like it will do the trick. What i was missing was things like arn.Parse and kinesis.ServiceID. Much better than me manually groveling the string!

Ok. Was able to make this work. Note: i needed to use .ServiceName not .ServiceID. Also, i needed to check for hte "0" value, not the "" value as it looks like that's what you get by default for integral values...

bflad · 2018-07-02T14:04:27Z

aws/resource_aws_lambda_event_source_mapping.go

 				ForceNew: true,
 			},
 			"batch_size": {
 				Type:     schema.TypeInt,
 				Optional: true,
-				Default:  100,


As mentioned, this change will likely require adding a DiffSuppressFunc to handle which API value is being returned depending on the event source type.

Done. Thanks!

Since we've modified the behavior of the attribute, we need to appropriately document those changes in website/docs/r/lambda_event_source_mapping.html.markdown

Makes sense. Just to check, but you're going to make that change, right? Or would you prefer i do it?

bflad · 2018-07-02T14:06:15Z

aws/resource_aws_lambda_event_source_mapping.go

+	err := resource.Retry(5*time.Minute, func() *resource.RetryError {
+		_, err := conn.DeleteEventSourceMapping(params)
+		if err != nil {
+			if awserr, ok := err.(awserr.Error); ok {


Minor nitpick: we have a helper function available for this type of logic and also prefer to use the SDK available constants, e.g. isAWSErr(err, lambda.ErrCodeResourceInUseException, "")

No worries about nits. I definitely want to do things "the right way". I did copy this code from elsewhere in hte project, so i thought that's what i was doing. But i'll de convert to this new form. Thanks!

bflad · 2018-07-02T14:07:22Z

aws/resource_aws_lambda_event_source_mapping.go

@@ -196,7 +213,9 @@ func resourceAwsLambdaEventSourceMappingUpdate(d *schema.ResourceData, meta inte
 		_, err := conn.UpdateEventSourceMapping(params)
 		if err != nil {
 			if awserr, ok := err.(awserr.Error); ok {
-				if awserr.Code() == "InvalidParameterValueException" {
+				if awserr.Code() == "InvalidParameterValueException" ||


Minor nitpick: we have a helper function available for this type of logic and also prefer to use the SDK available constants, e.g.

if isAWSErr(err, lambda.ErrCodeInvalidParameterValueException, "") || isAWSErr(err, lambda.ErrCodeResourceInUseException, "") {

Puneeth-n · 2018-07-02T15:01:33Z

aws/resource_aws_lambda_event_source_mapping_test.go

@@ -234,7 +325,7 @@ EOF
 resource "aws_iam_policy" "policy_for_role" {
    name = "%s"
    path = "/"
-    description = "IAM policy for for Lamda event mapping testing"
+    description = "IAM policy for for Lambda event mapping testing"
    policy = <<EOF


Done. Thanks!

Puneeth-n · 2018-07-02T15:01:44Z

aws/resource_aws_lambda_event_source_mapping_test.go

@@ -322,7 +414,7 @@ EOF
 resource "aws_iam_policy" "policy_for_role" {
    name = "%s"
    path = "/"
-    description = "IAM policy for for Lamda event mapping testing"
+    description = "IAM policy for for Lambda event mapping testing"


CyrusNajmabadi · 2018-07-02T21:44:32Z

@bflad This is ready for review again. Note, i have added the additional test to make sure batch_size works when removed. All tests pass:

cyrusn@matebunty ~/go/src/github.com/terraform-providers/terraform-provider-aws[patch-1 ≡]> make && make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaEventSourceMapping'
==> Checking that code complies with gofmt requirements...
go install
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLambdaEventSourceMapping -timeout 120m
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (107.03s)
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (104.82s)
=== RUN   TestAccAWSLambdaEventSourceMapping_sqs_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (92.34s)
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_import
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_import (91.84s)
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_disappears
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (89.31s)
=== RUN   TestAccAWSLambdaEventSourceMapping_sqsDisappears
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (112.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	597.853s

Hopefully this can go in soon :) let me know if tehre are more change you want me to make.

CyrusNajmabadi · 2018-07-03T17:29:10Z

@bflad Anything else you need from me at this point? Or is this ready to go in. Thanks! :)

bflad

LGTM, thanks @CyrusNajmabadi! 🚀 There's two items of feedback I'll handle on merge so we can get this released tonight/tomorrow.

 6 tests passed (all tests)
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_disappears
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (77.84s)
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_import
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_import (78.56s)
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (84.54s)
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (85.33s)
=== RUN   TestAccAWSLambdaEventSourceMapping_sqs_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (106.63s)
=== RUN   TestAccAWSLambdaEventSourceMapping_sqsDisappears
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (118.84s)

bflad · 2018-07-03T18:19:38Z

aws/resource_aws_lambda_event_source_mapping.go

 				ForceNew: true,
 			},
 			"batch_size": {
 				Type:     schema.TypeInt,
 				Optional: true,
-				Default:  100,
+				DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
+					// When AWS repurposed EventSourceMapping for use with SQS they kept


bflad · 2018-07-03T18:24:50Z

aws/resource_aws_lambda_event_source_mapping.go

+							return true
+						}
+					default:
+						panic(eventSourceARN.Service)


Usually panicking is incorrect within a Terraform provider as this often causes very confusing operator behavior (e.g. unexpected EOF errors). Instead, we should just silently do nothing here if another service, whether legit or not for usage for this resource, is passed in. With panic(), when new legitimate services are added, this would forcibly require everyone to upgrade iff the code updated. Without panic(), the more desirable behavior of perpetually showing a plan difference (ignorable with ignore_changes if necessary) is possible. We can use future issues to properly handle new services as required.

Makes sense!

bflad · 2018-07-03T18:28:37Z

aws/resource_aws_lambda_event_source_mapping.go

 				ForceNew: true,
 			},
 			"batch_size": {
 				Type:     schema.TypeInt,
 				Optional: true,
-				Default:  100,


Since we've modified the behavior of the attribute, we need to appropriately document those changes in website/docs/r/lambda_event_source_mapping.html.markdown

CyrusNajmabadi · 2018-07-03T23:57:33Z

@bflad Thanks! Just to make sure:

There's two items of feedback I'll handle on merge so we can get this released tonight/tomorrow.

So you don't want me to make any changes here right? You'll just tweak things on your end?

ryandeivert · 2018-07-04T00:05:55Z

huge thanks to @CyrusNajmabadi and @bflad for expediting this!

CyrusNajmabadi · 2018-07-04T06:38:08Z

Thanks all!

bflad · 2018-07-04T12:34:16Z

This has been released in version 1.26.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

ghost · 2020-04-04T17:50:20Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ghost added the size/XS Managed by automation to categorize the size of a PR. label Jun 28, 2018

CyrusNajmabadi mentioned this pull request Jun 28, 2018

Make EventSourceMapping.starting_position optional. pulumi/terraform-provider-aws#25

Merged

bflad added enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. labels Jun 29, 2018

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jun 29, 2018

ghost added size/L Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jun 29, 2018

CyrusNajmabadi and others added 3 commits June 29, 2018 14:37

Update documentatoin as well.

9fbac0d

Add event source mapping tests without a starting_position.

6230a5c

CyrusNajmabadi force-pushed the patch-1 branch from c439a7e to 6230a5c Compare June 29, 2018 21:38

ghost added the size/L Managed by automation to categorize the size of a PR. label Jun 29, 2018

flosell mentioned this pull request Jul 1, 2018

Feature request: SQS trigger lambda function #5030

Closed

ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 2, 2018

Remove the batch size default.

e595f05

It no longer applies as the sqs mapping default is 10.

CyrusNajmabadi force-pushed the patch-1 branch from 3b5a8e7 to e595f05 Compare July 2, 2018 09:56

ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 2, 2018

bflad reviewed Jul 2, 2018

View reviewed changes

Puneeth-n reviewed Jul 2, 2018

View reviewed changes

use appropriate terraform error helpers.

424624d

Fix test text duplication.

ee28487

ghost added the size/L Managed by automation to categorize the size of a PR. label Jul 2, 2018

Suppress diffs when batch_size is removed, but keeps the default size.

c8f892e

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Jul 2, 2018

Cleanup.

f69468a

CyrusNajmabadi force-pushed the patch-1 branch from 4541ee7 to f69468a Compare July 2, 2018 21:46

ghost added the size/XL Managed by automation to categorize the size of a PR. label Jul 2, 2018

bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 3, 2018

bflad approved these changes Jul 3, 2018

View reviewed changes

bflad merged commit f69468a into hashicorp:master Jul 3, 2018

bflad added this to the v1.26.0 milestone Jul 4, 2018

bflad added a commit that referenced this pull request Jul 4, 2018

Update CHANGELOG for #5024

5247217

CyrusNajmabadi deleted the patch-1 branch July 4, 2018 06:38

lukehoban mentioned this pull request Jul 4, 2018

InvalidParameterValueException: Maximum batch size must be between 1 and 10 inclusive pulumi/pulumi-aws-serverless#20

Closed

jason-riddle mentioned this pull request Jul 20, 2018

Updates to CloudFormationResourceSpecification.json? awslabs/goformation#91

Closed

jonrober mentioned this pull request Sep 11, 2018

Investigate why Terraform doesn't create Lambda triggers and have it done automatically if possible sul-dlss-deprecated/rialto#247

Closed

ghost locked and limited conversation to collaborators Apr 4, 2020

Make EventSourceMapping.starting_position optional. #5024

Make EventSourceMapping.starting_position optional. #5024

Conversation

CyrusNajmabadi commented Jun 28, 2018 • edited Loading

CyrusNajmabadi commented Jun 28, 2018

CyrusNajmabadi commented Jun 28, 2018

bflad commented Jun 29, 2018

CyrusNajmabadi commented Jun 29, 2018 • edited Loading

flosell commented Jul 1, 2018

ryandeivert commented Jul 1, 2018

CyrusNajmabadi commented Jul 2, 2018

CyrusNajmabadi commented Jul 2, 2018

CyrusNajmabadi commented Jul 2, 2018

CyrusNajmabadi commented Jul 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CyrusNajmabadi commented Jul 2, 2018

CyrusNajmabadi commented Jul 3, 2018

bflad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CyrusNajmabadi commented Jul 3, 2018

ryandeivert commented Jul 4, 2018

CyrusNajmabadi commented Jul 4, 2018

bflad commented Jul 4, 2018

ghost commented Apr 4, 2020

CyrusNajmabadi commented Jun 28, 2018 •

edited

Loading

CyrusNajmabadi commented Jun 29, 2018 •

edited

Loading