resource/aws_codebuild_project: Handle additional IAM retry case during update, remove update after create

[bflad]

Found via daily acceptance testing:

=== RUN   TestAccAWSCodeBuildProject_VpcConfig
--- FAIL: TestAccAWSCodeBuildProject_VpcConfig (15.89s)
	testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:
		
		* aws_codebuild_project.test: 1 error(s) occurred:
		
		* aws_codebuild_project.test: [ERROR] Error updating CodeBuild project (arn:aws:codebuild:us-west-2:*******:project/tf-acc-test-6715853446408871432): InvalidInputException: Not authorized to perform DescribeSecurityGroups

Changes proposed in this pull request:

• Retry InvalidInputException: Not authorized to perform DescribeSecurityGroups during update for IAM eventual consistency
• Call read after create instead of update

Output from acceptance testing:

20 tests passed (all tests)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodePipeline
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (19.34s)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (19.47s)
=== RUN   TestAccAWSCodeBuildProject_importBasic
--- PASS: TestAccAWSCodeBuildProject_importBasic (19.97s)
=== RUN   TestAccAWSCodeBuildProject_BadgeEnabled
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (27.46s)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_Bitbucket
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (27.99s)
=== RUN   TestAccAWSCodeBuildProject_basic
--- PASS: TestAccAWSCodeBuildProject_basic (28.06s)
=== RUN   TestAccAWSCodeBuildProject_WindowsContainer
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (28.29s)
=== RUN   TestAccAWSCodeBuildProject_Source_Auth
--- PASS: TestAccAWSCodeBuildProject_Source_Auth (28.26s)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_CodeCommit
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (28.30s)
=== RUN   TestAccAWSCodeBuildProject_Source_Type_S3
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (28.28s)
=== RUN   TestAccAWSCodeBuildProject_Source_ReportBuildStatus
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus (33.85s)
=== RUN   TestAccAWSCodeBuildProject_Source_InsecureSSL
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (33.95s)
=== RUN   TestAccAWSCodeBuildProject_Source_GitCloneDepth
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (34.01s)
=== RUN   TestAccAWSCodeBuildProject_BuildTimeout
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (34.16s)
=== RUN   TestAccAWSCodeBuildProject_Description
--- PASS: TestAccAWSCodeBuildProject_Description (34.36s)
=== RUN   TestAccAWSCodeBuildProject_Tags
--- PASS: TestAccAWSCodeBuildProject_Tags (34.43s)
=== RUN   TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (34.46s)
=== RUN   TestAccAWSCodeBuildProject_VpcConfig
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (34.79s)
=== RUN   TestAccAWSCodeBuildProject_EncryptionKey
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (45.74s)
=== RUN   TestAccAWSCodeBuildProject_Cache
--- PASS: TestAccAWSCodeBuildProject_Cache (52.16s)

[catsby]

👍

[bflad]

This has been released in version 1.30.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!