Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_lambda_permission: Add support for event_source_token #5264

Merged

Conversation

devonbleak
Copy link
Contributor

Fixes #2248

Changes proposed in this pull request:

  • Add support for event_source_token

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run TestAccAWSLambdaPermission'      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run TestAccAWSLambdaPermission -timeout 120m
=== RUN   TestAccAWSLambdaPermission_basic
--- PASS: TestAccAWSLambdaPermission_basic (39.94s)
=== RUN   TestAccAWSLambdaPermission_withRawFunctionName
--- PASS: TestAccAWSLambdaPermission_withRawFunctionName (39.41s)
=== RUN   TestAccAWSLambdaPermission_withStatementIdPrefix
--- PASS: TestAccAWSLambdaPermission_withStatementIdPrefix (41.77s)
=== RUN   TestAccAWSLambdaPermission_withQualifier
--- PASS: TestAccAWSLambdaPermission_withQualifier (43.35s)
=== RUN   TestAccAWSLambdaPermission_multiplePerms
--- PASS: TestAccAWSLambdaPermission_multiplePerms (59.57s)
=== RUN   TestAccAWSLambdaPermission_withS3
--- PASS: TestAccAWSLambdaPermission_withS3 (44.55s)
=== RUN   TestAccAWSLambdaPermission_withSNS
--- PASS: TestAccAWSLambdaPermission_withSNS (40.62s)
=== RUN   TestAccAWSLambdaPermission_withIAMRole
--- PASS: TestAccAWSLambdaPermission_withIAMRole (41.51s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       351.474s

$ make testacc TEST=./aws TESTARGS='-run TestValidateLambdaPermissionEventSourceToken'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run TestValidateLambdaPermissionEventSourceToken -timeout 120m
=== RUN   TestValidateLambdaPermissionEventSourceToken
--- PASS: TestValidateLambdaPermissionEventSourceToken (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1.559s

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jul 20, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. labels Jul 20, 2018
@bflad bflad added this to the v1.29.0 milestone Jul 26, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @devonbleak, thanks! 🚀

make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaPermission'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLambdaPermission -timeout 120m
=== RUN   TestAccAWSLambdaPermission_basic
--- PASS: TestAccAWSLambdaPermission_basic (35.18s)
=== RUN   TestAccAWSLambdaPermission_withRawFunctionName
--- PASS: TestAccAWSLambdaPermission_withRawFunctionName (32.56s)
=== RUN   TestAccAWSLambdaPermission_withStatementIdPrefix
--- PASS: TestAccAWSLambdaPermission_withStatementIdPrefix (32.30s)
=== RUN   TestAccAWSLambdaPermission_withQualifier
--- PASS: TestAccAWSLambdaPermission_withQualifier (25.79s)
=== RUN   TestAccAWSLambdaPermission_multiplePerms
--- PASS: TestAccAWSLambdaPermission_multiplePerms (48.74s)
=== RUN   TestAccAWSLambdaPermission_withS3
--- PASS: TestAccAWSLambdaPermission_withS3 (40.79s)
=== RUN   TestAccAWSLambdaPermission_withSNS
--- PASS: TestAccAWSLambdaPermission_withSNS (32.31s)
=== RUN   TestAccAWSLambdaPermission_withIAMRole
--- PASS: TestAccAWSLambdaPermission_withIAMRole (31.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	280.269s

@bflad bflad merged commit afbacf1 into hashicorp:master Jul 26, 2018
bflad added a commit that referenced this pull request Jul 26, 2018
@bflad
Copy link
Contributor

bflad commented Jul 26, 2018

This has been released in version 1.29.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@devonbleak devonbleak deleted the f-lambda-permission-event-source-token branch July 26, 2018 16:27
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform support for Alexa Smart Home Lambda trigger
2 participants