d/Adds a url_suffix attribute to data_source_aws_partition

[lorengordon]

Fixes #1960

Changes proposed in this pull request:

• Adds a urlsuffix attribute to the AWSClient struct
• Infers the urlsuffix value from the STS endpoint associated with the provider region
• Uses the new attribute to add a url_suffix attribute to data_source_aws_partition

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSPartition_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSPartition_basic -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSPartition_basic
--- PASS: TestAccAWSPartition_basic (4.34s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       4.379s

[bflad]

Hi @lorengordon 👋 Thanks for submitting this and apologies for the long silence here. I left some initial feedback below. Please let us know if you have any questions or do not have time to implement these items.

[bflad]

The comment notes inferring this information from the STS endpoint, however its using the states service.

That said, the AWS Go SDK documentation lists the XXXServiceID constants as deprecated: https://docs.aws.amazon.com/sdk-for-go/api/aws/endpoints/#pkg-constants

Deprecated: Use client package's EndpointsID value instead of these ServiceIDs. These IDs are not maintained, and are out of date.

This should be swapped out according to that deprecation.

Ideally though, we should fetch this information directly from the AWS Go SDK endpoints information first, then only fallback to parsing an endpoint should that fail since endpoint hostnames may not always follow a consistent implementation. I have submitted an upstream feature request in the AWS to directly provide the DNS suffix information, which can help prevent us from hardcoding these cases in the future: aws/aws-sdk-go#2710

[lorengordon]

This one I'm not sure when I'll have time to research and figure out the alternative. If anyone wants to take it, please be my guest!

[bflad]

Thanks so much for your patience, @lorengordon -- I was able to get the DNS suffix information visible from the AWS Go SDK (aws/aws-sdk-go#2711), rebase this PR, default to using that new information, and add verifying acceptance testing when setting the region to AWS Commercial, GovCloud (US), and China 👍

--- PASS: TestAccAWSPartition_basic (6.97s)

--- PASS: TestAccAWSProvider_Region_AwsCommercial (2.88s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (2.93s)
--- PASS: TestAccAWSProvider_Region_AwsChina (2.98s)

[lorengordon]

Brilliant! Thanks @bflad!

[ghost]

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!