Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ecr_repository: Use RepositoryUri for repository_url attribute #5748

Merged
merged 1 commit into from
Aug 31, 2018
Merged

resource/aws_ecr_repository: Use RepositoryUri for repository_url attribute #5748

merged 1 commit into from
Aug 31, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 31, 2018

Fixes #5741

Changes proposed in this pull request:

  • Use API RepositoryUri instead of custom built URL for aws_ecr_repository resource repository_url attribute
  • Refactors acceptance testing to remove import_*_test.go file and check registry_id/repository_url attribute values in Terraform state
  • Adds testAccCheckResourceAttrRegionalARN to start reducing usage of TestMatchResourceAttr for ARN attributes

Output from acceptance testing:

AWS Commercial:

--- PASS: TestAccAWSEcrRepository_basic (13.26s)

AWS GovCloud (US):

--- PASS: TestAccAWSEcrRepository_basic (19.02s)

@bflad
resource/aws_ecr_repository: Use RepositoryUri for repository_url att…
3ae9e05 
…ribute

Also refactors acceptance testing and begins implementation of helper ARN attribute TestCheckFunc.

AWS Commercial:

```
--- PASS: TestAccAWSEcrRepository_basic (13.26s)
```

AWS GovCloud (US):

```
--- PASS: TestAccAWSEcrRepository_basic (19.02s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/ecr Issues and PRs that pertain to the ecr service. partition/aws-cn Pertains to the aws-cn partition. labels Aug 31, 2018
@bflad bflad requested a review from a team August 31, 2018 12:37
@bflad bflad mentioned this pull request Aug 31, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

aws/provider_test.go Show resolved Hide resolved
@bflad bflad added this to the v1.35.0 milestone Aug 31, 2018
@bflad bflad merged commit e351bba into master Aug 31, 2018
@bflad bflad deleted the b-aws_ecr_repository-repository_url-cn branch August 31, 2018 14:01
bflad added a commit that referenced this pull request Aug 31, 2018
@bflad
Update CHANGELOG for #5748
876ecaf
@bflad
Copy link
Contributor Author

bflad commented Sep 6, 2018

This has been released in version 1.35.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. partition/aws-cn Pertains to the aws-cn partition. service/ecr Issues and PRs that pertain to the ecr service.
Projects
None yet
Milestone
v1.35.0
Development

Successfully merging this pull request may close these issues.

ecr_registry: repositry_url output doesn't support china/gov region
2 participants
@bflad @tombuildsstuff