Don't call DeleteUserPermissionsBoundary when deleting a user.

[mgarstecki]

Fixes #5856

Changes proposed in this pull request:

• Don't call DeleteUserPermissiosnBOundary when deleting an aws_iam_user : not needed, breaks use cases of permissions boundaries.

Output from acceptance testing:

$ make testacc TESTARGS="-run TestAccAWSUser"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run TestAccAWSUser -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSUser_importBasic
--- PASS: TestAccAWSUser_importBasic (22.72s)
=== RUN   TestAccAWSUserGroupMembership_basic
--- PASS: TestAccAWSUserGroupMembership_basic (113.06s)
=== RUN   TestAccAWSUserLoginProfile_basic
--- PASS: TestAccAWSUserLoginProfile_basic (51.24s)
=== RUN   TestAccAWSUserLoginProfile_keybase
--- PASS: TestAccAWSUserLoginProfile_keybase (33.73s)
=== RUN   TestAccAWSUserLoginProfile_keybaseDoesntExist
--- PASS: TestAccAWSUserLoginProfile_keybaseDoesntExist (23.26s)
=== RUN   TestAccAWSUserLoginProfile_notAKey
--- PASS: TestAccAWSUserLoginProfile_notAKey (23.68s)
=== RUN   TestAccAWSUserLoginProfile_PasswordLength
--- PASS: TestAccAWSUserLoginProfile_PasswordLength (32.21s)
=== RUN   TestAccAWSUserPolicyAttachment_basic
--- PASS: TestAccAWSUserPolicyAttachment_basic (52.19s)
=== RUN   TestAccAWSUserSSHKey_basic
--- PASS: TestAccAWSUserSSHKey_basic (26.47s)
=== RUN   TestAccAWSUserSSHKey_pemEncoding
--- PASS: TestAccAWSUserSSHKey_pemEncoding (24.41s)
=== RUN   TestAccAWSUser_basic
--- PASS: TestAccAWSUser_basic (37.98s)
=== RUN   TestAccAWSUser_disappears
--- PASS: TestAccAWSUser_disappears (15.66s)
=== RUN   TestAccAWSUser_nameChange
--- PASS: TestAccAWSUser_nameChange (38.40s)
=== RUN   TestAccAWSUser_pathChange
--- PASS: TestAccAWSUser_pathChange (37.62s)
=== RUN   TestAccAWSUser_permissionsBoundary
--- PASS: TestAccAWSUser_permissionsBoundary (68.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	601.032s

[bflad]

Thanks for finding and fixing this, @mgarstecki! I'm glad to see its no longer required like it was when the feature was initially released. 🚀

6 tests passed (all tests)
--- PASS: TestAccAWSUser_disappears (4.59s)
--- PASS: TestAccAWSUser_importBasic (6.82s)
--- PASS: TestAccAWSUser_nameChange (10.41s)
--- PASS: TestAccAWSUser_pathChange (10.78s)
--- PASS: TestAccAWSUser_basic (11.04s)
--- PASS: TestAccAWSUser_permissionsBoundary (19.18s)

[bflad]

This has been released in version 1.36.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!