resource/aws_network_acl_rule: Properly handle ICMP code and type with IPv6 ICMP (protocol 58) #6263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h IPv6 ICMP (protocol 58)
Previously:
```
--- FAIL: TestAccAWSNetworkAclRule_ipv6ICMP (12.47s)
testing.go:538: Step 0 error: Error applying: 1 error occurred:
* aws_network_acl_rule.test: 1 error occurred:
* aws_network_acl_rule.test: Error Creating Network Acl Rule: MissingParameter: The request must contain the parameter icmpTypeCode.type
status code: 400, request id: a0e8e287-af99-4da9-9b5f-e641e41d3fe7
```
Output from acceptance testing:
```
--- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (24.21s)
```
bflad
added
bug
ghost
added
size/S
tombuildsstuff
approved these changes
Oct 30, 2018
| @@ -139,7 +139,7 @@ func resourceAwsNetworkAclRuleCreate(d *schema.ResourceData, meta interface{}) e | |||
|
|
|||
| // Specify additional required fields for ICMP. For the list | |||
| // of ICMP codes and types, see: https://www.iana.org/assignments/icmp-parameters/icmp-parameters.xhtml | |||
| if p == 1 { | |||
| if p == 1 || p == 58 { | |||
There was a problem hiding this comment.
whilst this is clear in that there's a test for it - IMO we want a comment/constant to explain what these are so it doesn't require a lookup
There was a problem hiding this comment.
I hope #6302 covers this here as well. Probably best to solve this "globally". 😄
|
This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4737
Changes proposed in this pull request:
protocol58 to propagate ICMP code and type configurationPreviously:
Output from acceptance testing: