-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new data source type aws_autoscaling_group #6849
Add new data source type aws_autoscaling_group #6849
Conversation
…tion on a specific autoscaling group.
And for the sake of consistency, here is the output of the acceptance testing after my second commit:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @deberon 👋 Thanks for submitting this! I left some initial feedback below. Please let us know if you have any questions or do not have time to implement these items.
Wow! It was my first time writing in Go, could you tell? How do you prefer me to submit my patches? Should I squash the newer commits or do you guys like the verbose history? Thanks for the friendly feedback I will get started on it immediately. |
Hah, I don't judge, but you did pretty good considering that new fact to me. Setting up a Go environment for the first time, compiling a large project like this one, and developing/running integration testing is no small feat. Great job!
Verbose history or squashing is fine. We'll merge the commits either which way. |
…e names to fall in line with the attributes of the autoscaling_group resource
==> Checking that code complies with gofmt requirements... Also I see there's a conflict on website/aws.erb. I tried to lay my changes over the most current master copy but it's a popular repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @deberon, thanks! 🚀
--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (43.93s)
This has been released in version 1.54.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Fixes #6758
Changes proposed in this pull request:
Output from acceptance testing: