Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_availability_zones: Add blacklisted_names and blacklisted_zone_ids arguments #8463

Merged
merged 1 commit into from
May 1, 2019
Merged

data-source/aws_availability_zones: Add blacklisted_names and blacklisted_zone_ids arguments #8463

merged 1 commit into from
May 1, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 27, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8462

Output from acceptance testing:

--- PASS: TestAccAWSAvailabilityZones_basic (9.66s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (9.90s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedZoneIds (10.80s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedNames (10.80s)

@bflad
data-source/aws_availability_zones: Add blacklisted_names and blackli…
51bf2e8 
…sted_zone_ids arguments

Reference: #8462

Output from acceptance testing:

```
--- PASS: TestAccAWSAvailabilityZones_basic (9.66s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (9.90s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedZoneIds (10.80s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedNames (10.80s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. labels Apr 27, 2019
@bflad bflad requested a review from a team April 27, 2019 00:09
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 27, 2019
@nywilken nywilken added this to the v2.9.0 milestone May 1, 2019
nywilken
nywilken approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@nywilken nywilken merged commit b38d6df into master May 1, 2019
@nywilken nywilken deleted the f-aws_availability_zones-blacklists branch May 1, 2019 18:26
nywilken added a commit that referenced this pull request May 1, 2019
@nywilken
update CHANGELOG for #8463
4e7f1fc
@bflad bflad mentioned this pull request Jun 24, 2019
Closed
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

Add Blacklisting to aws_availability_zones Data Source
2 participants
@bflad @nywilken