New resources: aws_dx_hosted_transit_virtual_interface and aws_dx_hosted_transit_virtual_interface_accepter #8523

ewbankkit · 2019-05-03T21:55:41Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Part of the work for #8490.
Related:

New resource: aws_dx_transit_virtual_interface #8522

Acceptance tests (requires an existing Direct Connect connection in available state):

$ AWS_ALTERNATE_PROFILE=pppppppp DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedTransitVirtualInterface_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxHostedTransitVirtualInterface_basic -timeout 120m
=== RUN   TestAccAwsDxHostedTransitVirtualInterface_basic
=== PAUSE TestAccAwsDxHostedTransitVirtualInterface_basic
=== CONT  TestAccAwsDxHostedTransitVirtualInterface_basic
--- PASS: TestAccAwsDxHostedTransitVirtualInterface_basic (646.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	646.830s

n3ph

MTU of a transit virtual interface is 8500 - Not 9001

n3ph · 2019-05-07T12:38:21Z

website/docs/r/dx_hosted_transit_virtual_interface.html.markdown

+* `id` - The ID of the virtual interface.
+* `arn` - The ARN of the virtual interface.
+* `aws_device` - The Direct Connect endpoint on which the virtual interface terminates.
+* `jumbo_frame_capable` - Indicates whether jumbo frames (9001 MTU) are supported.


9001 vs. 8500

Whoops, missed that one; Fixed.

ewbankkit · 2019-07-26T18:40:56Z

Rebased to fix merge conflict.
@n3ph Are there any more review comments to address?

bflad

Hi again @ewbankkit 👋 Overall this looks good as well. Please reach out with any questions or if you do not have time to implement the feedback.

Since this Direct Connect resource testing requires a physical connection setup that the maintainers do not currently have access to, we can approve this pull request after the changes and two community acceptance test passing runs (one of these can be yours).

bflad · 2019-07-29T14:44:06Z

website/aws.erb

@@ -876,6 +876,12 @@
                                <li>
                                    <a href="/docs/providers/aws/r/dx_public_virtual_interface.html">aws_dx_public_virtual_interface</a>
                                </li>
+                                <li>
+                                    <a href="/docs/providers/aws/r/dx_hosted_transit_virtual_interface.html">aws_dx_hosted_transit_virtual_interface</a>


Nit: The sidebar should be alphabetically sorted

website/docs/r/dx_hosted_transit_virtual_interface.html.markdown

bflad · 2019-07-29T14:47:25Z

website/docs/r/dx_hosted_transit_virtual_interface_accepter.html.markdown

+* `virtual_interface_id` - (Required) The ID of the Direct Connect virtual interface to accept.
+* `tags` - (Optional) A mapping of tags to assign to the resource.
+
+### Removing `aws_dx_hosted_transit_virtual_interface_accepter` from your configuration


This section should instead be a note at the top of the resource page, using the ~> **NOTE:** Message here syntax

bflad · 2019-07-29T14:49:18Z

aws/resource_aws_dx_hosted_transit_virtual_interface_test.go

+	return nil
+}
+
+func testAccCheckAwsDxHostedTransitVirtualInterfaceExists(name string) resource.TestCheckFunc {


Same note as #8522 here -- the testAccCheck...Exists() should be verifying the infrastructure was properly created via the API -- similar but opposite of testAccCheckAwsDxHostedTransitVirtualInterfaceDestroy above. 👍

ewbankkit · 2019-07-30T23:23:50Z

@bflad Review comments addressed.
Similar changes for the acceptance tests as for aws_dx_transit_virtual_interface.

Latest acceptance tests:

$ AWS_ALTERNATE_PROFILE=pppppppp DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedTransitVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxHostedTransitVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxHostedTransitVirtualInterface
=== RUN   TestAccAwsDxHostedTransitVirtualInterface/basic
=== RUN   TestAccAwsDxHostedTransitVirtualInterface/accepterTags
--- PASS: TestAccAwsDxHostedTransitVirtualInterface (1734.33s)
    --- PASS: TestAccAwsDxHostedTransitVirtualInterface/basic (1078.51s)
    --- PASS: TestAccAwsDxHostedTransitVirtualInterface/accepterTags (655.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1734.409s

bflad · 2019-07-31T05:32:47Z

Thanks, @ewbankkit. Updates look great here too. If another person can verify the acceptance testing also passes on their own Direct Connect connection and show the output here, we'll merge this in. 👍

ewbankkit · 2019-07-31T17:19:46Z

One last change - Setting arn can be moved to the Read method now, removing duplicated code.
This can't be done for aws_dx_hosted_transit_virtual_interface_accepter as there's no way to set tags while confirming (accepting) the interface.

ewbankkit · 2019-08-02T21:38:05Z

Using common Exists and Destroy methods from #9572 in acceptance tests.
Acceptance tests:

$ AWS_ALTERNATE_PROFILE=pppppppp DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedTransitVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxHostedTransitVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxHostedTransitVirtualInterface
=== RUN   TestAccAwsDxHostedTransitVirtualInterface/basic
=== RUN   TestAccAwsDxHostedTransitVirtualInterface/accepterTags
--- PASS: TestAccAwsDxHostedTransitVirtualInterface (1360.23s)
    --- PASS: TestAccAwsDxHostedTransitVirtualInterface/basic (696.04s)
    --- PASS: TestAccAwsDxHostedTransitVirtualInterface/accepterTags (664.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1360.308s

jkodroff · 2019-08-06T22:48:20Z

@ryno75 You available to test this one?

ryno75 · 2019-08-27T20:34:11Z

oh geez... just seeing this now. I'll see if I can accommodate that.

…sit_virtual_interface_accepter' resources.

Co-Authored-By: Brian Flad <[email protected]>

…faces - hashicorp#8843.

… allowed on a Connection'.

…IF has been accepted.

ewbankkit · 2019-10-04T21:02:25Z

Rebased to fix conflicts and did the Terraform Plugin SDK migration for the new resources.

@ryno75 Will you be able to verify?
Thanks.

ewbankkit · 2019-11-07T14:19:32Z

Documentation changes for #10684.
Add subcategory: "Direct Connect" to the new markdown files above layout.
Done.

devonbleak · 2019-11-21T01:40:23Z

Are we just missing an additional test validation on this? I have a spare DX connection at the moment and can probably run this tomorrow if so.

ewbankkit · 2019-11-21T07:56:44Z

@devonbleak Yes, an additional test validation is all that is required and would be much appreciated; Thanks.

devonbleak · 2019-11-21T23:01:04Z

Confirming acceptance tests:

$ AWS_ALTERNATE_PROFILE=tf-test DX_CONNECTION_ID=dxcon-redacted make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedTransitVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsDxHostedTransitVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxHostedTransitVirtualInterface
=== RUN   TestAccAwsDxHostedTransitVirtualInterface/accepterTags
=== RUN   TestAccAwsDxHostedTransitVirtualInterface/basic
--- PASS: TestAccAwsDxHostedTransitVirtualInterface (1163.86s)
    --- PASS: TestAccAwsDxHostedTransitVirtualInterface/accepterTags (538.47s)
    --- PASS: TestAccAwsDxHostedTransitVirtualInterface/basic (625.38s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1165.061s

ewbankkit · 2019-11-22T12:34:27Z

@devonbleak Many thanks for the independent verification.
@bflad Any chance of getting this merged now? ~~I will address the refactor to use keyvaluetags via #9572.~~

bflad

This looks good, thanks @ewbankkit so much for all your work here (including keeping up with our development changes while this was pending) and @devonbleak for the testing assistance! 🚀

Approving per our community testing strategy for Direct Connect resources after code review. 👍

bflad · 2019-11-22T15:12:56Z

Aside: @devonbleak if any of the other open service/directconnect PRs interest your team as well, I believe there are a few others simply pending another testing run: https://github.com/terraform-providers/terraform-provider-aws/pulls?q=is%3Aopen+label%3Aservice%2Fdirectconnect+is%3Apr

ghost · 2019-11-27T00:03:40Z

This has been released in version 2.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-03-29T17:11:21Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit mentioned this pull request May 3, 2019

Allow aws_dx_gateway_association and aws_dx_private_virtual_interface to reference Transit Gateway #8490

Closed

ewbankkit changed the title ~~[WIP] New resources: aws_dx_hosted_transit_virtual_interface and aws_dx_hosted_transit_virtual_interface_accepter~~ New resources: aws_dx_hosted_transit_virtual_interface and aws_dx_hosted_transit_virtual_interface_accepter May 4, 2019

ewbankkit force-pushed the issue-8490.dx_hosted_transit_virtual_interface branch from b69e578 to 026110c Compare May 4, 2019 00:31

n3ph suggested changes May 7, 2019

View reviewed changes

ewbankkit mentioned this pull request May 12, 2019

Direct Connect hosted virtual interface cross-account tests #8608

Merged

aeschright requested a review from a team June 26, 2019 16:57

ewbankkit mentioned this pull request Jun 27, 2019

AWS Direct Connect resources: Add support for tag-on-create #9172

Closed

8 tasks

ewbankkit force-pushed the issue-8490.dx_hosted_transit_virtual_interface branch from bb809c8 to 63e159c Compare July 26, 2019 18:40

bflad added the new-resource Introduces a new resource. label Jul 29, 2019

bflad self-assigned this Jul 29, 2019

bflad reviewed Jul 29, 2019

View reviewed changes

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 29, 2019

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 30, 2019

ewbankkit mentioned this pull request Jul 31, 2019

Ensure correct VIF type during import of Direct Connect Virtual Interfaces #8843

Closed

ewbankkit mentioned this pull request Aug 2, 2019

Direct Connect virtual interfaces: Tag-on-create and validate type during import #9572

Merged

ewbankkit and others added 3 commits October 4, 2019 16:48

Add 'aws_dx_hosted_transit_virtual_interface' and 'aws_dx_hosted_tran…

26d9069

…sit_virtual_interface_accepter' resources.

Documentation fix after review.

9041922

Update website/docs/r/dx_hosted_transit_virtual_interface.html.markdown

97b7307

Co-Authored-By: Brian Flad <[email protected]>

Kit Ewbank and others added 7 commits October 4, 2019 16:49

Code changes after review.

96871b8

Ensure correct VIF type during import of Direct Connect Virtual Inter…

cd20140

…faces - hashicorp#8843.

Run acceptance tests serially: 'Only one Transit Virtual Interface is…

570cc62

… allowed on a Connection'.

'amazon_address' and 'customer_address' aren't set until the hosted V…

9606b7f

…IF has been accepted.

Set 'arn' in Read method. Remove duplicate code.

b0434ea

Use common 'Exists' and 'Destroy' methods - hashicorp#9572.

90f397e

Terraform Plugin SDK migration.

fea2d73

ewbankkit force-pushed the issue-8490.dx_hosted_transit_virtual_interface branch from 018fbcb to fea2d73 Compare October 4, 2019 21:00

paultyng unassigned bflad Nov 5, 2019

ewbankkit added 2 commits November 22, 2019 12:29

Add 'subcategory'.

05377e1

Add 'subcategory'.

63b0344

bflad self-requested a review November 22, 2019 15:02

bflad self-assigned this Nov 22, 2019

bflad approved these changes Nov 22, 2019

View reviewed changes

bflad added this to the v2.40.0 milestone Nov 22, 2019

bflad merged commit 16643d4 into hashicorp:master Nov 22, 2019

bflad added a commit that referenced this pull request Nov 22, 2019

Update CHANGELOG for #8523

3d369ef

ewbankkit deleted the issue-8490.dx_hosted_transit_virtual_interface branch November 22, 2019 16:55

ghost locked and limited conversation to collaborators Mar 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resources: aws_dx_hosted_transit_virtual_interface and aws_dx_hosted_transit_virtual_interface_accepter #8523

New resources: aws_dx_hosted_transit_virtual_interface and aws_dx_hosted_transit_virtual_interface_accepter #8523

ewbankkit commented May 3, 2019 •

edited

Loading

n3ph left a comment

n3ph May 7, 2019

ewbankkit May 7, 2019

ewbankkit commented Jul 26, 2019

bflad left a comment

bflad Jul 29, 2019

ewbankkit Jul 30, 2019

bflad Jul 29, 2019

ewbankkit Jul 30, 2019

bflad Jul 29, 2019

ewbankkit Jul 30, 2019

ewbankkit commented Jul 30, 2019

bflad commented Jul 31, 2019

ewbankkit commented Jul 31, 2019

ewbankkit commented Aug 2, 2019

jkodroff commented Aug 6, 2019

ryno75 commented Aug 27, 2019

ewbankkit commented Oct 4, 2019

ewbankkit commented Nov 7, 2019 •

edited

Loading

devonbleak commented Nov 21, 2019

ewbankkit commented Nov 21, 2019

devonbleak commented Nov 21, 2019

ewbankkit commented Nov 22, 2019 •

edited

Loading

bflad left a comment

bflad commented Nov 22, 2019

ghost commented Nov 27, 2019

ghost commented Mar 29, 2020

New resources: aws_dx_hosted_transit_virtual_interface and aws_dx_hosted_transit_virtual_interface_accepter #8523

New resources: aws_dx_hosted_transit_virtual_interface and aws_dx_hosted_transit_virtual_interface_accepter #8523

Conversation

ewbankkit commented May 3, 2019 • edited Loading

Community Note

n3ph left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewbankkit commented Jul 26, 2019

bflad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewbankkit commented Jul 30, 2019

bflad commented Jul 31, 2019

ewbankkit commented Jul 31, 2019

ewbankkit commented Aug 2, 2019

jkodroff commented Aug 6, 2019

ryno75 commented Aug 27, 2019

ewbankkit commented Oct 4, 2019

ewbankkit commented Nov 7, 2019 • edited Loading

devonbleak commented Nov 21, 2019

ewbankkit commented Nov 21, 2019

devonbleak commented Nov 21, 2019

ewbankkit commented Nov 22, 2019 • edited Loading

bflad left a comment

Choose a reason for hiding this comment

bflad commented Nov 22, 2019

ghost commented Nov 27, 2019

ghost commented Mar 29, 2020

ewbankkit commented May 3, 2019 •

edited

Loading

ewbankkit commented Nov 7, 2019 •

edited

Loading

ewbankkit commented Nov 22, 2019 •

edited

Loading