Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data sources for EBS default encryption #8884

Merged
merged 4 commits into from
Jun 26, 2019
Merged

Data sources for EBS default encryption #8884

merged 4 commits into from
Jun 26, 2019

Conversation

jukie
Copy link
Contributor

@jukie jukie commented Jun 5, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8772

Release note for CHANGELOG:

FEATURES:

* New Data Source: `aws_ebs_encryption_by_default`
* New Data Source: `aws_ebs_default_kms_key`

Output from acceptance testing:

$  make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsEBSEncryptionByDefault_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsEBSEncryptionByDefault_ -timeout 120m
=== RUN   TestAccDataSourceAwsEBSEncryptionByDefault_basic
=== PAUSE TestAccDataSourceAwsEBSEncryptionByDefault_basic
=== CONT  TestAccDataSourceAwsEBSEncryptionByDefault_basic
--- PASS: TestAccDataSourceAwsEBSEncryptionByDefault_basic (10.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.084s

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccDataSourceAwsEBSDefaultKmsKey_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccDataSourceAwsEBSDefaultKmsKey_ -timeout 120m
=== RUN   TestAccDataSourceAwsEBSDefaultKmsKey_basic
=== PAUSE TestAccDataSourceAwsEBSDefaultKmsKey_basic
=== CONT  TestAccDataSourceAwsEBSDefaultKmsKey_basic
--- PASS: TestAccDataSourceAwsEBSDefaultKmsKey_basic (10.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.655s
...

Also related to #8760

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 5, 2019
@bflad bflad added the new-data-source Introduces a new data source. label Jun 6, 2019
@jukie
Copy link
Contributor Author

jukie commented Jun 10, 2019 •
edited
Loading

@bflad I updated my branch to fix the merge conflict
Edit: and again to fix formatting

bflad
bflad suggested changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jukie 👋 Thanks for contributing this. Some small items and this should be good to go. Please reach out with any questions or if you do not have time to implement them.

aws/data_source_aws_ebs_default_kms_key.go Outdated Show resolved Hide resolved
aws/data_source_aws_ebs_default_kms_key.go Outdated Show resolved Hide resolved
aws/data_source_aws_ebs_default_kms_key_test.go Outdated Show resolved Hide resolved
website/docs/d/ebs_default_kms_key.html.markdown Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jun 20, 2019
@bflad bflad self-assigned this Jun 20, 2019
@jukie
Copy link
Contributor Author

jukie commented Jun 26, 2019

I'll update my branch now

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 26, 2019
@jukie @bflad
Use key_arn instead of key_id to match updated resource.
2bf9946 
Adds suggested changes from bflad

Co-Authored-By: Brian Flad <[email protected]>
@jukie jukie requested a review from a team June 26, 2019 02:11
@jukie
Copy link
Contributor Author

jukie commented Jun 26, 2019

@bflad should be ready now

@bflad bflad self-requested a review June 26, 2019 02:14
@bflad bflad added this to the v2.17.0 milestone Jun 26, 2019
bflad
bflad approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @jukie, thanks! 🚀

--- PASS: TestAccDataSourceAwsEBSEncryptionByDefault_basic (8.13s)
--- PASS: TestAccDataSourceAwsEBSDefaultKmsKey_basic (8.16s)

@bflad bflad merged commit 6b848e1 into hashicorp:master Jun 26, 2019
bflad added a commit that referenced this pull request Jun 26, 2019
@bflad
Update CHANGELOG for #8884
092c802
@bflad
Copy link
Contributor

bflad commented Jun 28, 2019

This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@parroty parroty mentioned this pull request Oct 19, 2019
Merged
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/kms Issues and PRs that pertain to the kms service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.17.0
Development

Successfully merging this pull request may close these issues.

Data sources for EBS default encryption
3 participants
@jukie @bflad @justinretzolk